From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AB3AB1FF13A for ; Wed, 13 May 2026 10:15:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 09AEE27A3; Wed, 13 May 2026 10:15:48 +0200 (CEST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 13 May 2026 10:15:09 +0200 Message-Id: Subject: Re: [PATCH manager v3] ui: ha: add disarm/re-arm button From: "Dominik Rusovac" To: "Dominik Rusovac" , X-Mailer: aerc 0.20.0 References: <20260416112033.148589-1-d.rusovac@proxmox.com> In-Reply-To: <20260416112033.148589-1-d.rusovac@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778659996171 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.348 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2LVTYQLLVSHGNYC4RDTAFJO7HE6FIWWD X-Message-ID-Hash: 2LVTYQLLVSHGNYC4RDTAFJO7HE6FIWWD X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Superseded-by: https://lore.proxmox.com/all/20260513081123.1042628-1-d.ruso= vac@proxmox.com/ On Thu Apr 16, 2026 at 1:20 PM CEST, Dominik Rusovac wrote: > The button to disarm HA in either of the resource modes ('freeze' or > 'ignore') is disabled as long as HA is disarmed. Analogously, the button > to arm HA is disabled as long as HA is not disarmed. > > For feedback, after clicking either of the buttons, icon spins as long as > (dis)arming process has not changed the armed-state of HA. > > The icons ('unlink' and 'link') are chosen to emphasize that "Disarm HA" > and "Arm HA" are complements. There may be more suitable pairs of icons > though. > > Signed-off-by: Dominik Rusovac > --- > changes since v2: > * inline setting isDisarmed flag > * use 'tbar' > * switch positions of buttons > * hook into 'hastatuschange' to provide feedback via spinning icon while > armed-state of HA changes: > - add 'isDisarmedPendingState' to controller=20 > - on successful (dis)arm request, store expected 'isDisarmed'-value=20 > in 'isDisarmedPendingState'=20 > - match 'isDisarmedPendingState' on 'isDisarmed' in 'hastatuschange'=20 > and clear 'isDisarmedPendingState' > > www/manager6/ha/Status.js | 113 ++++++++++++++++++++++++++++++++++ > www/manager6/ha/StatusView.js | 8 +++ > 2 files changed, 121 insertions(+) > [snip]