public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Dominik Rusovac" <d.rusovac@proxmox.com>
To: "Daniel Kral" <d.kral@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH pve-ha-manager 6/7] api: status: add load imbalance to status
Date: Wed, 29 Apr 2026 10:49:32 +0200	[thread overview]
Message-ID: <DI5ICN5KRBZL.170X7D4317KEV@proxmox.com> (raw)
In-Reply-To: <DI4O6F13YF11.1YSL3VGME67PU@proxmox.com>

On Tue Apr 28, 2026 at 11:10 AM CEST, Daniel Kral wrote:
> On Mon Apr 27, 2026 at 3:20 PM CEST, Dominik Rusovac wrote:
>> This is a very basic measure to enable users to detect the prevailing
>> load imbalance in the UI, which atm reveals nothing about the latter.
>>
>> imo, enabling users to track how the load imbalance changed over time
>> (using RRD graphs, for example) should be considered, in the long run.
>>
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>>  src/PVE/API2/HA/Status.pm | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/API2/HA/Status.pm b/src/PVE/API2/HA/Status.pm
>> index 4894f3b..acec78e 100644
>> --- a/src/PVE/API2/HA/Status.pm
>> +++ b/src/PVE/API2/HA/Status.pm
>> @@ -199,7 +199,9 @@ __PACKAGE__->register_method({
>>              }
>>              my $datacenter_config = eval { cfs_read_file('datacenter.cfg') } // {};
>>              if (my $crs = $datacenter_config->{crs}) {
>> -                $extra_status .= " - $crs->{ha} load CRS"
>> +                $extra_status .=
>> +                    " - $crs->{ha} load CRS "
>> +                    . sprintf("(load imbalance: %.2f", 100 * $status->{imbalance}) . "%)"
>>                      if $crs->{ha} && $crs->{ha} ne 'basic';
>
> I think this should also check whether the load balancing system is
> enabled to not clutter the status string if it's unused or no action is
> taken if this value is high, but no hard feelings.
>

good point, thx! will adjust the clause

>>              }
>>              my $time_str = localtime($status->{timestamp});





  reply	other threads:[~2026-04-29  8:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 13:20 [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox 0/7] clamp load imbalance to unit interval Dominik Rusovac
2026-04-27 13:20 ` [PATCH proxmox 1/7] resource-scheduling: clamp imbalance value " Dominik Rusovac
2026-04-28  9:05   ` Daniel Kral
2026-04-29  7:18     ` Dominik Rusovac
2026-04-27 13:20 ` [PATCH proxmox 2/7] resource-scheduling: re-adjust hardcoded imbalance values Dominik Rusovac
2026-04-28  8:53   ` Daniel Kral
2026-04-29  7:18     ` Dominik Rusovac
2026-04-27 13:20 ` [PATCH pve-manager 3/7] ui: from/CRSOptions: add maximum for threshold Dominik Rusovac
2026-04-28  8:52   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-ha-manager 4/7] test: re-adjust logged imbalance values Dominik Rusovac
2026-04-28  8:52   ` Daniel Kral
2026-04-29  8:26     ` Dominik Rusovac
2026-04-27 13:20 ` [PATCH pve-ha-manager 5/7] manager: add load imbalance to status Dominik Rusovac
2026-04-28  9:20   ` Daniel Kral
2026-04-27 13:20 ` [PATCH pve-ha-manager 6/7] api: status: " Dominik Rusovac
2026-04-28  9:10   ` Daniel Kral
2026-04-29  8:49     ` Dominik Rusovac [this message]
2026-04-27 13:20 ` [PATCH pve-cluster 7/7] datacenter config: add maxima for load scheduler options Dominik Rusovac
2026-04-28  8:53   ` Daniel Kral
2026-04-29  7:48     ` Dominik Rusovac
2026-04-28  9:21 ` [RFC PATCH-SERIES cluster/ha-manager/manager/proxmox 0/7] clamp load imbalance to unit interval Daniel Kral
2026-04-29 12:23 ` Dominik Rusovac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DI5ICN5KRBZL.170X7D4317KEV@proxmox.com \
    --to=d.rusovac@proxmox.com \
    --cc=d.kral@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal