Re: [PATCH pve-cluster 7/7] datacenter config: add maxima for load scheduler options

["Dominik Rusovac" <d.rusovac@proxmox.com>]

On Tue Apr 28, 2026 at 10:53 AM CEST, Daniel Kral wrote:
> On Mon Apr 27, 2026 at 3:20 PM CEST, Dominik Rusovac wrote:
>> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
>> ---
>>  src/PVE/DataCenterConfig.pm | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
>> index 6513594..d120017 100644
>> --- a/src/PVE/DataCenterConfig.pm
>> +++ b/src/PVE/DataCenterConfig.pm
>> @@ -44,6 +44,7 @@ EODESC
>>          type => 'number',
>>          optional => 1,
>>          minimum => 0.0,
>> +        maximum => 1.0,
>>          default => 0.3,
>>          requires => 'ha-auto-rebalance',
>>          description => "The threshold for the cluster node imbalance, which will"
>> @@ -72,6 +73,7 @@ EODESC
>>          type => 'number',
>>          optional => 1,
>>          minimum => 0.0,
>> +        maximum => 1.0,
>
> Oh right, this should have already been there before as reducing the
> imbalance by more than 100 % makes no sense ;-).
>
>>          default => 0.1,
>>          requires => 'ha-auto-rebalance',
>>          description => "The minimum relative improvement in cluster node"
>
> nit: would be nice to have some patch message here too why those changes
> are fine to make it a little more explicit and the changes to margin
> syncs with what is already done in the web interface AFAICT.

ack, will add text