public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH manager] fix #6211: ui: vm: options: add tooltip to protection option
@ 2026-07-13 11:46 Elias Huhsovitz
  2026-07-15 12:17 ` Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Elias Huhsovitz @ 2026-07-13 11:46 UTC (permalink / raw)
  To: pve-devel; +Cc: Elias Huhsovitz

The "protection" options was ambiguous.
Add tooltip to briefly describe the option.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
 www/manager6/qemu/Options.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
index 8a4721a0..9ade5ccb 100644
--- a/www/manager6/qemu/Options.js
+++ b/www/manager6/qemu/Options.js
@@ -326,6 +326,10 @@ Ext.define('PVE.qemu.Options', {
                               defaultValue: 0,
                               deleteDefaultValue: true,
                               fieldLabel: gettext('Enabled'),
+                              afterLabelTextTpl: ' <i class="fa fa-question-circle" style="color: #888; cursor: help; margin-left: 4px;"></i>',
+                              autoEl: {
+                                  'data-qtip': gettext('Prevents the VM and its disks from being removed')
+                              }
                           },
                       }
                     : undefined,
-- 
2.47.3





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH manager] fix #6211: ui: vm: options: add tooltip to protection option
  2026-07-13 11:46 [PATCH manager] fix #6211: ui: vm: options: add tooltip to protection option Elias Huhsovitz
@ 2026-07-15 12:17 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-07-15 12:17 UTC (permalink / raw)
  To: Elias Huhsovitz, pve-devel

would speak anything against putting the icon into the 'boxLabel'
instead of to the fieldlabel?

that would put it right next to the actual checkbox and not
to the relatively generic 'enabled' label
i think our users should now what 'enabled' means, but
what we want to convey is the meaning of the actual option

On 7/13/26 1:47 PM, Elias Huhsovitz wrote:
> The "protection" options was ambiguous.
> Add tooltip to briefly describe the option.
> 
> Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
> ---
>   www/manager6/qemu/Options.js | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/www/manager6/qemu/Options.js b/www/manager6/qemu/Options.js
> index 8a4721a0..9ade5ccb 100644
> --- a/www/manager6/qemu/Options.js
> +++ b/www/manager6/qemu/Options.js
> @@ -326,6 +326,10 @@ Ext.define('PVE.qemu.Options', {
>                                 defaultValue: 0,
>                                 deleteDefaultValue: true,
>                                 fieldLabel: gettext('Enabled'),
> +                              afterLabelTextTpl: ' <i class="fa fa-question-circle" style="color: #888; cursor: help; margin-left: 4px;"></i>',
> +                              autoEl: {
> +                                  'data-qtip': gettext('Prevents the VM and its disks from being removed')
> +                              }
>                             },
>                         }
>                       : undefined,





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-15 12:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13 11:46 [PATCH manager] fix #6211: ui: vm: options: add tooltip to protection option Elias Huhsovitz
2026-07-15 12:17 ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal