public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* ui: make selection fields searchable
@ 2026-07-14 11:10 666Goofy666
  2026-07-15  7:42 ` Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: 666Goofy666 @ 2026-07-14 11:10 UTC (permalink / raw)
  To: pve-devel@lists.proxmox.com

Hi,
thanks for your continued work on Proxmox.

I would like to make pools and bridges forms selection fields searchable 

I tried something like this patch : https://lore.proxmox.com/pve-devel/20240412091613.30038-1-f.ebner@proxmox.com/ to `pve-manager/www/manager6/form/PoolSelector.js` and it works as expected.

However, for `pve-manager/www/manager6/form/BridgeSelector.js` the situation is a bit different because the current behavior should be preserved: select the first filtered element

at `pve-manager/www/manager6/qemu/NetworkEdit.js:83` and LXC (implicite true) there is `autoSelect: true` which is handled/overridden at `proxmox-widget-toolkit/src/form/ComboGrid.js:435`
This makes searching impossible, because as soon as one character is typed, the first result is match.

What would be the recommended approach?

Thanks,

Goofy





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: ui: make selection fields searchable
  2026-07-14 11:10 ui: make selection fields searchable 666Goofy666
@ 2026-07-15  7:42 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2026-07-15  7:42 UTC (permalink / raw)
  To: 666Goofy666, pve-devel@lists.proxmox.com



On 7/14/26 1:20 PM, 666Goofy666 wrote:
> Hi,
> thanks for your continued work on Proxmox.
> 
> I would like to make pools and bridges forms selection fields searchable
> 
> I tried something like this patch : https://lore.proxmox.com/pve-devel/20240412091613.30038-1-f.ebner@proxmox.com/ to `pve-manager/www/manager6/form/PoolSelector.js` and it works as expected.
> 
> However, for `pve-manager/www/manager6/form/BridgeSelector.js` the situation is a bit different because the current behavior should be preserved: select the first filtered element
> 
> at `pve-manager/www/manager6/qemu/NetworkEdit.js:83` and LXC (implicite true) there is `autoSelect: true` which is handled/overridden at `proxmox-widget-toolkit/src/form/ComboGrid.js:435`
> This makes searching impossible, because as soon as one character is typed, the first result is match.
> 
> What would be the recommended approach?
> 
> Thanks,
> 
> Goofy
> 
> 
> 
> 
> 
Hi and thanks for wanting to contribute!

I had a short look and it seems that there are some issues with this in 
our ComboGrid implementation.

The 'autoSelect' actually does two things:

* extjs selects the first entry when the picker is opened
* the combogrid selects the first entry from the store on the first load

The issue here is that the autoselect behavior from extjs causes
the first entry in the grid to be selected, which steals
the focus from the actual field, and this triggers the validator
(which is not valid when one has only types a single character most of 
the time)

I have to think about this a bit how to solve it, but maybe we have
to teach the combogrid to not take the focus away from the field
when the first item is selected?

I'll try to see what i can do here, but would you mind opening
a bug for your features in the meantime:

https://bugzilla.proxmox.com

i'd update it then with this info and when
the underlying issues are resolved.
(not sure how long that takes though...)


Simply disabling autoSelect is not really what we want here, because
of the second behavior i mentioned above.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-15  7:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 11:10 ui: make selection fields searchable 666Goofy666
2026-07-15  7:42 ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal