public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: Elias Huhsovitz <e.huhsovitz@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager] Web UI: VM creation Wizard: Pupulate EFI and TPM storage by default
Date: Wed, 5 Aug 2026 12:03:54 +0200	[thread overview]
Message-ID: <73bc945e-f210-4a98-abfc-5a2c69763ef4@proxmox.com> (raw)
In-Reply-To: <DKGVPX5BAWGM.JWIPM5O2CVIE@proxmox.com>

On 8/5/26 10:49, Elias Huhsovitz wrote:
> Nice quality of life change! Just one small bug:
>
> The "EFI Storage" and "TPM Storage" fields are only populated the first
> time the options are selected.
>
> Repeatedly selecting/unselecting the checkboxes "Addi EFI Disk" and "Add
> TPM", will not cause the respective storage fields to be populated, reverting
> to the old behaviour.
According to my very limited knowledge of Javascript and our implementation
this might be expected or working as intended?

Since the autoSelect property is mapped as a CBind in
[pve-manager.git] / www / manager6 / form / IsoSelector.js
> 76             cbind: {
> 77                 nodename: '{nodename}',
> 78                 autoSelect: '{insideWizard}',
> 79                 insideWizard: '{insideWizard}',
> 80                 disabled: '{disabled}',
> 81                 labelWidth: '{labelWidth}',
> 82                 labelAlign: '{labelAlign}',
> 83             }
and [proxmox-widget-toolkit.git] / src / mixin / CBind.js states
> 2  * The Proxmox CBind mixin is intended to supplement the 'bind' 
> mechanism
> 3  * of ExtJS. In contrast to the 'bind', 'cbind' only acts during the 
> creation
> 4  * of the component, not during its lifetime. It's only applied once 
> before
> 5  * the 'initComponent' method is executed, and thus you have only access
> 6  * to the basic initial configuration of it.
i assume the selector is not recreated after un- and reticking the checkbox.

For regular disks this situation never arose afaict since the entry is 
always
freshly created.

I currently don't know where to look for the culprit here or maybe am even
on the wrong track and am open for suggestions.




  reply	other threads:[~2026-08-05 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-03 11:05 [PATCH pve-manager] Web UI: VM creation Wizard: Pupulate EFI and TPM storage by default Jonas Theisen
2026-08-05  8:49 ` Elias Huhsovitz
2026-08-05 10:03   ` Jonas Theisen [this message]
2026-08-05 13:52     ` [PATCH manager] ui: vm: create: fix autoSelect for disk storage selector when re-enabling field Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73bc945e-f210-4a98-abfc-5a2c69763ef4@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal