Re: [PATCH manager] ui: vm: create: fix autoSelect for disk storage selector when re-enabling field

[Elias Huhsovitz <e.huhsovitz@proxmox.com>]

The `autoSelect` configuration in `DiskStorageSelector` relies on the
underlying `ComboGrid` store's `load` event to select the first
available storage.

When the field is disabled and subsequently re-enabled, the
`load` event does not fire again. Consequently, the field remains
empty despite `autoSelect` being configured.

Fix this by explicitly handling the auto-selection logic inside the
`setDisabled` method. When the field is being enabled and is
currently empty, select the first record from the cached store.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
My knowledge of javacsript is also very limited, but this small
patch is how i would fix this.

TL;DR:
The original code only triggered autoSelect when the storage list downloaded
from the server. Toggling the checkbox does not trigger a new download, so
the event never fired again.

The fix intercepts the exact moment the field turns back on. It manually grabs
the first storage from the browser's existing memory cache and sets it
immediately.

Let me know what you think of this approach.

Note: I also noticed that your commit message has a typo.
"Pupulate" -> "Populate"

 www/manager6/form/DiskStorageSelector.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js
index 696f9033..f0af07ec 100644
--- a/www/manager6/form/DiskStorageSelector.js
+++ b/www/manager6/form/DiskStorageSelector.js
@@ -117,6 +117,11 @@ Ext.define('PVE.form.DiskStorageSelector', {
         // reset on disable
         if (value) {
             hdstorage.setValue();
+        } else if (me.autoSelect && !hdstorage.getValue()) {
+            let rec = hdstorage.getStore().first();
+            if (rec && rec.data) {
+                hdstorage.setValue(rec.data[hdstorage.valueField], true);
+            }
         }
         hdstorage.setDisabled(value);

--
2.47.3