From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager/network/proxmox-ve-rs 0/4] Expose OSPF Network-Type option
Date: Thu, 16 Apr 2026 17:29:29 +0200 [thread overview]
Message-ID: <68ac2bff-ad10-4e6e-a347-e4b54b5482e0@proxmox.com> (raw)
In-Reply-To: <20260218151153.381963-1-g.goller@proxmox.com>
doesn't apply anymore - please rebase!
On 2/18/26 4:12 PM, Gabriel Goller wrote:
> Previously the network-type option on OSPF interfaces was set to either
> point-to-point or broadcast, depending on if an ip address was configured on
> the interface. This is not enough, as some users want to have a switched
> network (e.g. switch) between their nodes, which calls for the
> point-to-multipoint network type.
>
> In order to uphold backwards-compatibility, make network-type an `Option`,
> where `None` will be the "automatic" network-type selection we had before.
>
>
> ┌──────────┐ ┌──────────────┐ ┌───────────────────┐ ┌───┐
> │None(auto)│ │Point-to-Point│ │Point-to-Multipoint│ │...│
> └────┬─────┘ └──────────────┘ └───────────────────┘ └───┘
> │
> ▼
> ┌─────────────────┐
> │Is there an ip │
> │on the interface?│
> └──┬────────────┬─┘
> │no │yes
> ▼ ▼
> ┌──────────────┐ ┌────────────────────────┐
> │Point-to-Point│ │No FRR network statement│
> └──────────────┘ └───────────┬────────────┘
> │
> ▼
> ┌────────────────────────────┐
> │FRR selects either Broadcast│
> │Point-to-Point or Loopback │
> │(internal network-type) │
> └────────────────────────────┘
>
>
> This series relies on the template series:
> https://lore.proxmox.com/pve-devel/20260203160246.353351-1-g.goller@proxmox.com/
>
> proxmox-ve-rs:
>
> Gabriel Goller (2):
> cargo: bump proxmox-network-types
> fabrics: ospf: expose network-type interface property
>
> Cargo.toml | 2 +-
> proxmox-frr/debian/control | 4 +--
> proxmox-frr/src/ser/ospf.rs | 27 +---------------
> proxmox-sdn-types/debian/control | 3 +-
> proxmox-sdn-types/src/lib.rs | 1 +
> proxmox-sdn-types/src/ospf.rs | 32 +++++++++++++++++++
> proxmox-ve-config/debian/control | 8 ++---
> proxmox-ve-config/src/sdn/fabric/frr.rs | 13 +++++---
> .../fabric/section_config/protocol/ospf.rs | 6 ++++
> 9 files changed, 57 insertions(+), 39 deletions(-)
> create mode 100644 proxmox-sdn-types/src/ospf.rs
>
>
> pve-network:
>
> Gabriel Goller (1):
> fabrics: add ospf network_type property to interfaces
>
> src/PVE/Network/SDN/Fabrics.pm | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
> pve-manager:
>
> Gabriel Goller (1):
> fabrics: ospf: add network-type property in interface panel
>
> .../sdn/fabrics/ospf/InterfacePanel.js | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
>
> Summary over all repositories:
> 11 files changed, 117 insertions(+), 39 deletions(-)
>
prev parent reply other threads:[~2026-04-16 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 15:11 Gabriel Goller
2026-02-18 15:11 ` [PATCH proxmox-ve-rs 1/2] cargo: bump proxmox-network-types Gabriel Goller
2026-02-18 15:11 ` [PATCH proxmox-ve-rs 2/2] fabrics: ospf: expose network-type interface property Gabriel Goller
2026-02-18 15:11 ` [PATCH pve-network 1/1] fabrics: add ospf network_type property to interfaces Gabriel Goller
2026-02-18 15:11 ` [PATCH pve-manager 1/1] fabrics: ospf: add network-type property in interface panel Gabriel Goller
2026-04-16 15:29 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68ac2bff-ad10-4e6e-a347-e4b54b5482e0@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox