From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A01611FF13C for ; Thu, 16 Apr 2026 17:29:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 77925B072; Thu, 16 Apr 2026 17:29:34 +0200 (CEST) Message-ID: <68ac2bff-ad10-4e6e-a347-e4b54b5482e0@proxmox.com> Date: Thu, 16 Apr 2026 17:29:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager/network/proxmox-ve-rs 0/4] Expose OSPF Network-Type option To: pve-devel@lists.proxmox.com References: <20260218151153.381963-1-g.goller@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20260218151153.381963-1-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.689 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fabrics.pm,frr.rs,ospf.rs,proxmox.com,lib.rs] Message-ID-Hash: HV2ZYYEPTUP3CDACJB5J2QNLWRM7J5KH X-Message-ID-Hash: HV2ZYYEPTUP3CDACJB5J2QNLWRM7J5KH X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: doesn't apply anymore - please rebase! On 2/18/26 4:12 PM, Gabriel Goller wrote: > Previously the network-type option on OSPF interfaces was set to either > point-to-point or broadcast, depending on if an ip address was configured on > the interface. This is not enough, as some users want to have a switched > network (e.g. switch) between their nodes, which calls for the > point-to-multipoint network type. > > In order to uphold backwards-compatibility, make network-type an `Option`, > where `None` will be the "automatic" network-type selection we had before. > > > ┌──────────┐ ┌──────────────┐ ┌───────────────────┐ ┌───┐ > │None(auto)│ │Point-to-Point│ │Point-to-Multipoint│ │...│ > └────┬─────┘ └──────────────┘ └───────────────────┘ └───┘ > │ > ▼ > ┌─────────────────┐ > │Is there an ip │ > │on the interface?│ > └──┬────────────┬─┘ > │no │yes > ▼ ▼ > ┌──────────────┐ ┌────────────────────────┐ > │Point-to-Point│ │No FRR network statement│ > └──────────────┘ └───────────┬────────────┘ > │ > ▼ > ┌────────────────────────────┐ > │FRR selects either Broadcast│ > │Point-to-Point or Loopback │ > │(internal network-type) │ > └────────────────────────────┘ > > > This series relies on the template series: > https://lore.proxmox.com/pve-devel/20260203160246.353351-1-g.goller@proxmox.com/ > > proxmox-ve-rs: > > Gabriel Goller (2): > cargo: bump proxmox-network-types > fabrics: ospf: expose network-type interface property > > Cargo.toml | 2 +- > proxmox-frr/debian/control | 4 +-- > proxmox-frr/src/ser/ospf.rs | 27 +--------------- > proxmox-sdn-types/debian/control | 3 +- > proxmox-sdn-types/src/lib.rs | 1 + > proxmox-sdn-types/src/ospf.rs | 32 +++++++++++++++++++ > proxmox-ve-config/debian/control | 8 ++--- > proxmox-ve-config/src/sdn/fabric/frr.rs | 13 +++++--- > .../fabric/section_config/protocol/ospf.rs | 6 ++++ > 9 files changed, 57 insertions(+), 39 deletions(-) > create mode 100644 proxmox-sdn-types/src/ospf.rs > > > pve-network: > > Gabriel Goller (1): > fabrics: add ospf network_type property to interfaces > > src/PVE/Network/SDN/Fabrics.pm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > > pve-manager: > > Gabriel Goller (1): > fabrics: ospf: add network-type property in interface panel > > .../sdn/fabrics/ospf/InterfacePanel.js | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > > > Summary over all repositories: > 11 files changed, 117 insertions(+), 39 deletions(-) >