Re: [PATCH ha-manager v4 14/27] api: resources: migration: support additional migration options

[Fiona Ebner <f.ebner@proxmox.com>]

Am 16.10.26 um 11:54 AM schrieb Daniel Kral:
> On Thu Oct 15, 2026 at 2:50 PM CEST, Fiona Ebner wrote:
>>  src/PVE/API2/HA/Resources.pm | 110 ++++++++++++++++++++++++++++++-----
>>  src/PVE/HA/Resources.pm      |   1 +
>>  2 files changed, 97 insertions(+), 14 deletions(-)
>>
>> diff --git a/src/PVE/API2/HA/Resources.pm b/src/PVE/API2/HA/Resources.pm
>> index b96572b..6a97b2f 100644
>> --- a/src/PVE/API2/HA/Resources.pm
>> +++ b/src/PVE/API2/HA/Resources.pm
>> @@ -3,15 +3,20 @@ package PVE::API2::HA::Resources;
>>  use strict;
>>  use warnings;
>>  
>> +use JSON qw();
>> +
>> +use PVE::Exception qw(raise_param_exc);
>>  use PVE::SafeSyslog;
>>  use PVE::Tools qw(extract_param);
>>  use PVE::Cluster;
>>  use PVE::HA::Config;
>> +use PVE::HA::Env::PVE2;
> 
> Why depend on PVE2 here?

For registering the resource plugins. I'll add a comment.

> 
>>  use PVE::HA::Resources;
>>  use HTTP::Status qw(:constants);
>>  use Storable qw(dclone);
>>  use PVE::JSONSchema qw(get_standard_option);
>>  use PVE::RPCEnvironment;
>> +use PVE::RESTEnvironment qw(log_warn);
>>  
>>  use PVE::RESTHandler;
>>  
>> @@ -34,6 +39,49 @@ my $api_copy_config = sub {
>>      return $scfg;
>>  };
>>  
>> +my sub migrate_json_properties {
>> +    my ($type) = @_;
>> +    my $plugin = PVE::HA::Resources->lookup($type);
>> +    return $plugin->migrate_json_properties();
>> +}
>> +
>> +my sub json_crm_command_is_supported {
> 
> nit: should probably include _motion to specify that it only checks
>      whether the migrate JSON command is supported

The intention is to extend it later when another JSON command becomes
available, but fair enough, it can always be renamed later on :)

> 
>> +    PVE::Cluster::cfs_update();
>> +    my $version_info = PVE::Cluster::get_node_kv('version-info');
>> +    for my $node (sort keys $version_info->%*) {
>> +        my $node_info = eval { JSON::decode_json($version_info->{$node}); };
>> +        if (my $err = $@) {
>> +            # An updated cluster is the usual situation. An error here should not affect the usual
>> +            # situation. The unusual situation, where the master is too old and unable to report its
>> +            # version properly is rare. Submitting a JSON CRM to such a master will lead to warnings
>> +            # and the command being ignored. Note that migration without extra parameters also still
>> +            # works.
>> +            log_warn("failed check for migration options support - cannot parse version info for"
>> +                . " node '$node' - $err");
>> +        } elsif (!PVE::Cluster::pvecfg_min_version($node_info->{version}, 9, 2, 22)) {
>> +            return 0;
>> +        }
>> +    }
>> +
>> +    return 1;
>> +}
>> +
>> +my sub json_crm_command_is_applicable {
> 
> nit: should probably include _motion to specify that it only checks
>      whether the migrate JSON command is applicable

Ack