public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v4 27/27] ui: migrate: add checkbox to allow skipping newly enforced config check
Date: Thu, 15 Oct 2026 14:51:01 +0200	[thread overview]
Message-ID: <20261015125112.174954-28-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261015125112.174954-1-f.ebner@proxmox.com>

Since qemu-server and pve-container commits "migration: intra-cluster:
check config can be parsed on target node", there is an early check
that the target can successfully parse the guest configuration. There
is an escape hatch to skip the check with the 'skip-config-check'
parameter, to force migration regardless. Allow using the escape hatch
from the UI too.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Should depend on new pve-container, qemu-server and ha-manager so the
node version checking makes sense.

New in v4.

 www/manager6/window/Migrate.js | 39 ++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js
index 8cac54ea..6f48d131 100644
--- a/www/manager6/window/Migrate.js
+++ b/www/manager6/window/Migrate.js
@@ -31,6 +31,7 @@ Ext.define('PVE.window.Migrate', {
                 hasLocalResources: false,
                 withConntrackState: true,
                 bothHaveDbusVmstate: false,
+                configCheck: true,
             },
         },
         formulas: {
@@ -150,6 +151,10 @@ Ext.define('PVE.window.Migrate', {
                 params['with-conntrack-state'] = 1;
             }
 
+            if (!vm.get('migration.configCheck')) {
+                params['skip-config-check'] = 1;
+            }
+
             Proxmox.Utils.API2Request({
                 params: params,
                 url:
@@ -468,6 +473,13 @@ Ext.define('PVE.window.Migrate', {
                 }
             }
 
+            if (!vm.get('migration.configCheck')) {
+                const text = gettext(
+                    'Without the config check, an outdated target node might drop configuration settings it cannot parse.',
+                );
+                migration.preconditions.push({ text, severity: 'warning' });
+            }
+
             vm.set('migration', migration);
         },
         checkLxcPreconditions: async function (resetMigrationPossible) {
@@ -563,6 +575,13 @@ Ext.define('PVE.window.Migrate', {
                 }
             }
 
+            if (!vm.get('migration.configCheck')) {
+                const text = gettext(
+                    'Without the config check, an outdated target node might ignore configuration settings it cannot parse.',
+                );
+                migration.preconditions.push({ text, severity: 'warning' });
+            }
+
             vm.set('migration', migration);
         },
     },
@@ -602,6 +621,26 @@ Ext.define('PVE.window.Migrate', {
                                 value: '{setMigrationMode}',
                             },
                         },
+                        {
+                            xtype: 'proxmoxcheckbox',
+                            name: 'configCheck',
+                            fieldLabel: gettext('Config Check'),
+                            autoEl: {
+                                tag: 'div',
+                                'data-qtip': gettext(
+                                    'Check that the target node can parse the guest configuration.',
+                                ),
+                            },
+                            bind: {
+                                value: '{migration.configCheck}',
+                            },
+                            listeners: {
+                                change: {
+                                    fn: 'checkMigratePreconditions',
+                                    extraArg: true,
+                                },
+                            },
+                        },
                     ],
                 },
                 {
-- 
2.47.3





      parent reply	other threads:[~2026-10-15 12:54 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 12:50 [PATCH-SERIES many v4 00/27] migration: strict config check for intra-cluster migration Fiona Ebner
2026-10-15 12:50 ` [PATCH common v4 01/27] tools: move version_cmp() helper from qemu-server Fiona Ebner
2026-10-15 12:50 ` [PATCH common v4 02/27] rest handler: handle: respect schema's 'type-property' when resolving type Fiona Ebner
2026-10-15 12:50 ` [PATCH cluster v4 03/27] cluster: move pvecfg node version helpers from qemu-server Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 04/27] update crm commands: align logging with next state started/stopped Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 05/27] manager: factor out helper to check if requested resource motion is valid Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 06/27] next state stopped: align logging for motion command with next_state_started() Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 07/27] next state {stopped,started}: factor out helper to handle motion command Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 08/27] lrm: resource migration: support extra migration options Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 09/27] change service state: support hash as a parameter value Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 10/27] next state: handle motion command: support migration options Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 11/27] resources: add migrate_json_properties() method Fiona Ebner
2026-10-16  9:51   ` Daniel Kral
2026-10-15 12:50 ` [PATCH ha-manager v4 12/27] queue resource motion: support migration options Fiona Ebner
2026-10-15 12:50 ` [PATCH ha-manager v4 13/27] crm command: support JSON-style migrate command Fiona Ebner
2026-10-16  9:53   ` Daniel Kral
2026-10-15 12:50 ` [PATCH ha-manager v4 14/27] api: resources: migration: support additional migration options Fiona Ebner
2026-10-16  9:54   ` Daniel Kral
2026-10-15 12:50 ` [PATCH ha-manager v4 15/27] test: add test for " Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 16/27] helpers: move version_cmp() helper to pve-common Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 17/27] helpers: move pvecfg node version helpers to pve-cluster Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 18/27] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 19/27] fix #7053: api: migrate: pass 'with-conntrack-state' flag to HA migration Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 20/27] qm: mtunnel: reply when a command is unknown Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 21/27] qm: mtunnel: add 'conf' command to do strict configuration parsing Fiona Ebner
2026-10-15 12:50 ` [PATCH qemu-server v4 22/27] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-10-15 12:50 ` [PATCH container v4 23/27] api: migrate: allow forwarding certain migration properties to HA Fiona Ebner
2026-10-15 12:50 ` [PATCH container v4 24/27] pct: introduce mtunnel command Fiona Ebner
2026-10-15 12:50 ` [PATCH container v4 25/27] d/control: bump versioned build dependency for libpve-common-perl to 9.0.12 Fiona Ebner
2026-10-15 12:51 ` [PATCH container v4 26/27] migration: intra-cluster: check config can be parsed on target node Fiona Ebner
2026-10-15 12:51 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261015125112.174954-28-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal