From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager] ui: processor edit: fix clipped accel hint in VM creation wizard
Date: Tue, 19 May 2026 18:36:34 +0200 [thread overview]
Message-ID: <65b26c4e-6eb1-4eba-96ea-f5d8e30c527e@proxmox.com> (raw)
In-Reply-To: <20260519095752.310312-1-a.bied-charreton@proxmox.com>
Am 19.05.26 um 11:57 schrieb Arthur Bied-Charreton:
> The 200px height on the flag selector leaves no room for the
> acceleration hint below it in the wizard's layout.
>
> Decrease the flag selector's default height to 180px so everything
> fits.
>
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
> www/manager6/form/VMCPUFlagSelector.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index c6f8f87a..a62353aa 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -16,7 +16,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
> selectable: false,
>
> scrollable: 'y',
> - height: 200,
> + height: 180,
>
> emptyText: gettext('No CPU flags available'),
>
thanks, I rechecked the UI/UX another time here and found the permanently visible
hint a bit to alarming/distracting, especially given that the TCG case is rather
an edge case.
After trying a few things I then went for increasing the wizard base size a bit [0]
and moving the hint as simple string inside the VMCPUFlagSelector's bottom bar, i.e.
to the right of the "Only show flags supported by at least one node" checkbox, and
only made it visible for VM vCPU edit case, as in the datacenter custom vCPU case
it's more explicit due to the KVM/TCG filter anyway.
[0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=7de57108172a31eebe35a565d3c5b1966a32a9a7
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=db71b84bbc08482130c7d51db24a416ab7af74f7
prev parent reply other threads:[~2026-05-19 16:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 9:57 [PATCH pve-manager] ui: processor edit: fix clipped accel hint in VM creation wizard Arthur Bied-Charreton
2026-05-19 16:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65b26c4e-6eb1-4eba-96ea-f5d8e30c527e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox