From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 137DE1FF141 for ; Tue, 19 May 2026 18:37:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E18A9E031; Tue, 19 May 2026 18:37:08 +0200 (CEST) Message-ID: <65b26c4e-6eb1-4eba-96ea-f5d8e30c527e@proxmox.com> Date: Tue, 19 May 2026 18:36:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH pve-manager] ui: processor edit: fix clipped accel hint in VM creation wizard To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260519095752.310312-1-a.bied-charreton@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20260519095752.310312-1-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779208580433 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LCGY5ZT5D2DYOIWDNMOEPKUZ3F3G7FYL X-Message-ID-Hash: LCGY5ZT5D2DYOIWDNMOEPKUZ3F3G7FYL X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 19.05.26 um 11:57 schrieb Arthur Bied-Charreton: > The 200px height on the flag selector leaves no room for the > acceleration hint below it in the wizard's layout. > > Decrease the flag selector's default height to 180px so everything > fits. > > Signed-off-by: Arthur Bied-Charreton > --- > www/manager6/form/VMCPUFlagSelector.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js > index c6f8f87a..a62353aa 100644 > --- a/www/manager6/form/VMCPUFlagSelector.js > +++ b/www/manager6/form/VMCPUFlagSelector.js > @@ -16,7 +16,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', { > selectable: false, > > scrollable: 'y', > - height: 200, > + height: 180, > > emptyText: gettext('No CPU flags available'), > thanks, I rechecked the UI/UX another time here and found the permanently visible hint a bit to alarming/distracting, especially given that the TCG case is rather an edge case. After trying a few things I then went for increasing the wizard base size a bit [0] and moving the hint as simple string inside the VMCPUFlagSelector's bottom bar, i.e. to the right of the "Only show flags supported by at least one node" checkbox, and only made it visible for VM vCPU edit case, as in the datacenter custom vCPU case it's more explicit due to the KVM/TCG filter anyway. [0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=7de57108172a31eebe35a565d3c5b1966a32a9a7 https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=db71b84bbc08482130c7d51db24a416ab7af74f7