Re: [PATCH manager v3 00/13] ui: split out disks and nics into grids

[Dominik Csapak <d.csapak@proxmox.com>]

sorry this should have been v4, resending now....

On 5/15/26 10:54 AM, Dominik Csapak wrote:
> This is basically a complete rework of the series. Since the need
> for having the buttons in all grids made things a bit more complicated
> than i anticipated.
> 
> I factored out a few things, so it's easier to reuse (especially since i
> want to do the same thing for containers when we figured out if the
> style/layout/etc. fits)
> 
> Sending again qemu only for now as i don't want to put in a lot of work
> before we know which direction this will take.
> 
> I tried to keep most commits small so it's easier to see what the actual
> change are.
> 
> NOTE: I took special care for the button enablement logic, but having a close
> look at that during review would make a lot of sense.
> 
> changes from v2:
> * reorganized code/commits for the most part, so it doesn't make much
>    sense to compare it to the previous version
> 
> changes from v1:
> * refactor some regexes/checks
> * fix some bugs I encountered during testing again
> 
> Dominik Csapak (13):
>    ui: utils: factor out 'media=cdrom' check
>    ui: factor out the guest key nic regex check
>    ui: parser: qemu drive: allow '-' in key names
>    ui: add pending grid
>    ui: revert button: add parentXType and reloadCallback
>    ui: button: add config remove button
>    ui: qemu: hardware: wrap in container
>    ui: qemu: introduce hardware disk grid
>    ui: qemu: introduce hardware net grid
>    ui: qemu: hardware view: separate disks into own grid
>    ui: qemu: hardware view: separate nics into own grid
>    ui: qemu: hardware view: inline edit/remove/revert button in general
>      grid
>    ui: qemu: hardware view: inline 'add efi' menuitem
> 
>   www/manager6/Makefile                 |   4 +
>   www/manager6/Parser.js                |   2 +-
>   www/manager6/Utils.js                 |  23 +-
>   www/manager6/button/ConfigRemove.js   |  74 +++
>   www/manager6/button/Revert.js         |   8 +-
>   www/manager6/grid/PendingGrid.js      | 134 ++++
>   www/manager6/lxc/Network.js           |   4 +-
>   www/manager6/qemu/BootOrderEdit.js    |  12 +-
>   www/manager6/qemu/CreateWizard.js     |   4 +-
>   www/manager6/qemu/HardwareDiskGrid.js | 213 ++++++
>   www/manager6/qemu/HardwareNetGrid.js  |  81 +++
>   www/manager6/qemu/HardwareView.js     | 925 +++++++++++++++-----------
>   www/manager6/window/GuestImport.js    |   2 +-
>   13 files changed, 1079 insertions(+), 407 deletions(-)
>   create mode 100644 www/manager6/button/ConfigRemove.js
>   create mode 100644 www/manager6/grid/PendingGrid.js
>   create mode 100644 www/manager6/qemu/HardwareDiskGrid.js
>   create mode 100644 www/manager6/qemu/HardwareNetGrid.js
>