From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v3 00/13] ui: split out disks and nics into grids
Date: Fri, 15 May 2026 10:44:18 +0200 [thread overview]
Message-ID: <20260515085349.1123127-1-d.csapak@proxmox.com> (raw)
This is basically a complete rework of the series. Since the need
for having the buttons in all grids made things a bit more complicated
than i anticipated.
I factored out a few things, so it's easier to reuse (especially since i
want to do the same thing for containers when we figured out if the
style/layout/etc. fits)
Sending again qemu only for now as i don't want to put in a lot of work
before we know which direction this will take.
I tried to keep most commits small so it's easier to see what the actual
change are.
NOTE: I took special care for the button enablement logic, but having a close
look at that during review would make a lot of sense.
changes from v2:
* reorganized code/commits for the most part, so it doesn't make much
sense to compare it to the previous version
changes from v1:
* refactor some regexes/checks
* fix some bugs I encountered during testing again
Dominik Csapak (13):
ui: utils: factor out 'media=cdrom' check
ui: factor out the guest key nic regex check
ui: parser: qemu drive: allow '-' in key names
ui: add pending grid
ui: revert button: add parentXType and reloadCallback
ui: button: add config remove button
ui: qemu: hardware: wrap in container
ui: qemu: introduce hardware disk grid
ui: qemu: introduce hardware net grid
ui: qemu: hardware view: separate disks into own grid
ui: qemu: hardware view: separate nics into own grid
ui: qemu: hardware view: inline edit/remove/revert button in general
grid
ui: qemu: hardware view: inline 'add efi' menuitem
www/manager6/Makefile | 4 +
www/manager6/Parser.js | 2 +-
www/manager6/Utils.js | 23 +-
www/manager6/button/ConfigRemove.js | 74 +++
www/manager6/button/Revert.js | 8 +-
www/manager6/grid/PendingGrid.js | 134 ++++
www/manager6/lxc/Network.js | 4 +-
www/manager6/qemu/BootOrderEdit.js | 12 +-
www/manager6/qemu/CreateWizard.js | 4 +-
www/manager6/qemu/HardwareDiskGrid.js | 213 ++++++
www/manager6/qemu/HardwareNetGrid.js | 81 +++
www/manager6/qemu/HardwareView.js | 925 +++++++++++++++-----------
www/manager6/window/GuestImport.js | 2 +-
13 files changed, 1079 insertions(+), 407 deletions(-)
create mode 100644 www/manager6/button/ConfigRemove.js
create mode 100644 www/manager6/grid/PendingGrid.js
create mode 100644 www/manager6/qemu/HardwareDiskGrid.js
create mode 100644 www/manager6/qemu/HardwareNetGrid.js
--
2.47.3
next reply other threads:[~2026-05-15 8:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 8:44 Dominik Csapak [this message]
2026-05-15 8:44 ` [PATCH manager v3 01/13] ui: utils: factor out 'media=cdrom' check Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 02/13] ui: factor out the guest key nic regex check Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 03/13] ui: parser: qemu drive: allow '-' in key names Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 04/13] ui: add pending grid Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 05/13] ui: revert button: add parentXType and reloadCallback Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 06/13] ui: button: add config remove button Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 07/13] ui: qemu: hardware: wrap in container Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 08/13] ui: qemu: introduce hardware disk grid Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 09/13] ui: qemu: introduce hardware net grid Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 10/13] ui: qemu: hardware view: separate disks into own grid Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 11/13] ui: qemu: hardware view: separate nics " Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 12/13] ui: qemu: hardware view: inline edit/remove/revert button in general grid Dominik Csapak
2026-05-15 8:44 ` [PATCH manager v3 13/13] ui: qemu: hardware view: inline 'add efi' menuitem Dominik Csapak
2026-05-15 9:18 ` [PATCH manager v3 00/13] ui: split out disks and nics into grids Dominik Csapak
2026-05-15 9:20 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515085349.1123127-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox