public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Kaiyang Wu <wukaiyang2003@gmail.com>
To: pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH container] setup: fedora: disable static units when fixing up template
Date: Mon, 13 Jul 2026 11:16:18 +0800	[thread overview]
Message-ID: <5924d4fe-0b65-4525-9c76-9e1bd8c1989a@gmail.com> (raw)
In-Reply-To: <20260708101037.54778-1-wukaiyang2003@gmail.com>

Gentle ping, can anyone please take a look?

Kaiyang

On 2026-07-08 18:10, wukaiyang2003@gmail.com wrote:
> From: Kaiyang Wu <wukaiyang@loongfans.cn>
> 
> Fedora ships 'sys-mount-{config,debug}.mount' units as static units,
> which would cause the units failing on startup.
> 
> Use the disable static units helper when fixing up templates to resolve
> the issue, similar to how we process CentOS LXC templates.
> 
> Signed-off-by: Kaiyang Wu <wukaiyang@loongfans.cn>
> ---
>   src/PVE/LXC/Setup/Fedora.pm | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm
> index cf383e3..91880dd 100644
> --- a/src/PVE/LXC/Setup/Fedora.pm
> +++ b/src/PVE/LXC/Setup/Fedora.pm
> @@ -27,6 +27,8 @@ sub template_fixup {
>       $self->ct_unlink('/etc/systemd/system/getty@.service');
>   
>       $self->remove_lxc_name_from_etc_hosts();
> +
> +    $self->setup_systemd_disable_static_units();
>   }
>   
>   sub setup_init {




      reply	other threads:[~2026-07-13  3:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 10:10 [PATCH container] setup: fedora: disable static units when fixing up template wukaiyang2003
2026-07-13  3:16 ` Kaiyang Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5924d4fe-0b65-4525-9c76-9e1bd8c1989a@gmail.com \
    --to=wukaiyang2003@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal