From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9CEEC1FF0F1 for ; Mon, 13 Jul 2026 05:17:03 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 77E4B213E3; Mon, 13 Jul 2026 05:17:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783912581; x=1784517381; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RaZY4Q2eUalMKFlFVfZk4Pf+I+iG8F5KBhtdYaHEyfY=; b=Fy9GR/bLoOqFMOcGl5doaZq/J5f4MROuLEYUMX8sxcN72BHQgND3BeDOrO/8z7OREB KA7G06UTFP7Njerl4v/K4CvKy5Tub/UEXq4rdZIWZrdaIU3rtSSErAleIf9bEdfcQFVH patK9l3QjYR5GJEtOFJnPd6q59LKHHkJijQojd9xP91zYEUIm6q5gdvT1kwyzkoxexgo jviwMkolYtkeLqVX1l6TVItS+V1W9MezAgaqSn7eL0d9v7CH6nPXgUSajA6TAGECnAeF Q5C2mGLgETS8r8IRVJJ4I2i0Kis44juun68/vAnJnwmFK3hi5NwNe+Bb8SgfxgJ3B1n7 F1Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783912581; x=1784517381; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RaZY4Q2eUalMKFlFVfZk4Pf+I+iG8F5KBhtdYaHEyfY=; b=NcGlYlHDiWFRwnP7EBAvl5Lhde5SMjKwMwAN2yV7JRbSBtwOjXcUcjB/PMrsy7KvJa XRM97u0s3xnApS9nXGyPMh2Qnhu4ykeJdgT9jOwQctoQ6axc5VEbKE/vytABi/JeLEsl G4S2N+9OEDq22eSWi5CcBdrk4CCni6m0em0gAIlJt07YAf4CiopvTr8MO9YkdmkdcUvj SLMi90AtT78jc0C+PF8ydQeYN6qoYt2DJjO46vofskFT2kCF6vggR4Rec5Q+9EtpxvEP nGiXVeJ0OKqpTKcSrq+ZXH/NV1Rd46tDHWoo17eJEN9XhekP5ouwe1CODU45fnKj3QfS 5Snw== X-Gm-Message-State: AOJu0YzLLwmiM9O4d+Nw5udQgSgiNbqnoIefQ5sXrzZSxRRSvtWsVQQd 7MEDpkz6cRlqThQui7EkAtmMDPpQc1WEi1SkuEqxD8OGBiNnij68AJMwG356fIbJERk= X-Gm-Gg: AfdE7cl6HLQQMckBMyvlwQSeneNGspWdrTyqnOtUbaLDVsifx9NI1NDBqMOPVxl2xkd 4A9/SrQIeZcKNywF/gL4qBrybQqNzFfVcJaG3i7voRnL445b71ccpwT/ZFRbkmHfh2DQHWvnPGt mJ/zV8/BjLFAoPgSsfEQgf3MCcJ86xpTzB63gq3WpFvY0RSVSa+ciWgtwVfhB1nVH47NbtPhgIt LQidKB7SDGoX+pMtOieJMHaqixkn2mxKJEetWGXWZ3aF/7EHOgWTg/CVgq8b5ZApiUT9UBg5RIL M11E4MTJzrcw4pBF46Y52Ozji4F1MEQx0d9Cojnv0Df5AP1/HNpiP4WI1qpmrFH1plXGavs5lzn RmuVfalwOfstK6XdRsSLvYxJAFqH+5+gOogKQZjLGnWxqC0M8Owi9o2xb+Y7yxJj8gqG5ODgg0Y TbMG6AZhNyj2/1rSsw X-Received: by 2002:a17:90a:d2c4:b0:38d:d9a7:a4e9 with SMTP id 98e67ed59e1d1-38dd9a7aa3amr3346411a91.11.1783912581072; Sun, 12 Jul 2026 20:16:21 -0700 (PDT) Message-ID: <5924d4fe-0b65-4525-9c76-9e1bd8c1989a@gmail.com> Date: Mon, 13 Jul 2026 11:16:18 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH container] setup: fedora: disable static units when fixing up template To: pve-devel@lists.proxmox.com References: <20260708101037.54778-1-wukaiyang2003@gmail.com> Content-Language: en-US From: Kaiyang Wu In-Reply-To: <20260708101037.54778-1-wukaiyang2003@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider KAM_SHORT 0.001 Use of a URL Shortener for very short URL RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XCHR4EROIHR7VZHOLYWLOYE5DWB73K76 X-Message-ID-Hash: XCHR4EROIHR7VZHOLYWLOYE5DWB73K76 X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Gentle ping, can anyone please take a look? Kaiyang On 2026-07-08 18:10, wukaiyang2003@gmail.com wrote: > From: Kaiyang Wu > > Fedora ships 'sys-mount-{config,debug}.mount' units as static units, > which would cause the units failing on startup. > > Use the disable static units helper when fixing up templates to resolve > the issue, similar to how we process CentOS LXC templates. > > Signed-off-by: Kaiyang Wu > --- > src/PVE/LXC/Setup/Fedora.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm > index cf383e3..91880dd 100644 > --- a/src/PVE/LXC/Setup/Fedora.pm > +++ b/src/PVE/LXC/Setup/Fedora.pm > @@ -27,6 +27,8 @@ sub template_fixup { > $self->ct_unlink('/etc/systemd/system/getty@.service'); > > $self->remove_lxc_name_from_etc_hosts(); > + > + $self->setup_systemd_disable_static_units(); > } > > sub setup_init {