Re: [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling

[Fiona Ebner <f.ebner@proxmox.com>]

Ping, this also fixes the following bug reported a few days after I sent
the series:
https://bugzilla.proxmox.com/show_bug.cgi?id=8092

Am 25.09.26 um 2:27 PM schrieb Fiona Ebner:
> When removing a volume chain snapshot, the blockdev properties are
> re-generated in blockdev_{commit,replace,stream}() to operate upon.
> This must happen with the current drive information, not the one from
> the time the snapshot was taken.
> 
> A similar bug was present before volume chain snapshots existed, and
> fixed by commit c6058683 ("fix #2258: select correct device when
> removing drive snapshot via QEMU"). This is where the handling for
> $attached_deviceid comes from. With snapshot-as-volume-chain, this
> needs to be extended to the full drive information, not just the
> device ID.
> 
> Includes some extra preparation which allows moving the functions to a
> separate module and getting rid of two calls from QemuConfig back to
> QemuServer making progress towards getting rid of that cyclic
> dependency.
> 
> Also does some further unrelated cleanup in the VolumeChain module,
> that was noticed while looking over the code.
> 
> qemu-server:
> 
> Fiona Ebner (7):
>   volume snapshot (delete): avoid using deprecated check_running()
>     helper
>   volume snapshot delete: move getting attached device ID to caller
>   fix #8071: volume snapshot delete: use current drive information to
>     fix SAVC handling
>   snapshot: add module for snapshot-related functionality
>   snapshot: use v5.36 and subroutine signatures
>   volume chain: blockdev delete: remove superfluous parse_volume_id()
>     call
>   volume chain: blockdev delete: pass volume ID instead of drive and
>     mark private
> 
>  src/PVE/QemuConfig.pm             |  27 ++++-
>  src/PVE/QemuServer.pm             | 163 +-----------------------------
>  src/PVE/QemuServer/Makefile       |   1 +
>  src/PVE/QemuServer/Snapshot.pm    | 155 ++++++++++++++++++++++++++++
>  src/PVE/QemuServer/VolumeChain.pm |  18 ++--
>  src/test/snapshot-test.pm         |   7 +-
>  6 files changed, 194 insertions(+), 177 deletions(-)
>  create mode 100644 src/PVE/QemuServer/Snapshot.pm
> 
> 
> Summary over all repositories:
>   6 files changed, 194 insertions(+), 177 deletions(-)
>