From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 5/7] snapshot: use v5.36 and subroutine signatures
Date: Fri, 25 Sep 2026 14:26:29 +0200 [thread overview]
Message-ID: <20260925122646.139215-6-f.ebner@proxmox.com> (raw)
In-Reply-To: <20260925122646.139215-1-f.ebner@proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/QemuServer/Snapshot.pm | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/src/PVE/QemuServer/Snapshot.pm b/src/PVE/QemuServer/Snapshot.pm
index a0d4c239..50f6ac67 100644
--- a/src/PVE/QemuServer/Snapshot.pm
+++ b/src/PVE/QemuServer/Snapshot.pm
@@ -1,7 +1,6 @@
package PVE::QemuServer::Snapshot;
-use strict;
-use warnings;
+use v5.36;
use PVE::Storage;
@@ -11,9 +10,7 @@ use PVE::QemuServer::Machine;
use PVE::QemuServer::Monitor qw(qmp_cmd);
use PVE::QemuServer::VolumeChain;
-sub do_snapshots_type {
- my ($storecfg, $drive, $deviceid, $running) = @_;
-
+sub do_snapshots_type($storecfg, $drive, $deviceid, $running) {
#we use storage snapshot if vm is not running or if disk is unused;
return 'storage' if !$running || !$deviceid;
@@ -31,9 +28,7 @@ sub do_snapshots_type {
return 'storage';
}
-sub qemu_volume_snapshot {
- my ($vmid, $deviceid, $storecfg, $drive, $snap) = @_;
-
+sub qemu_volume_snapshot($vmid, $deviceid, $storecfg, $drive, $snap) {
my $volid = $drive->{file};
my $running = PVE::QemuServer::Helpers::vm_running_locally($vmid);
@@ -64,9 +59,7 @@ sub qemu_volume_snapshot {
}
}
-sub qemu_volume_snapshot_delete {
- my ($vmid, $storecfg, $drive, $snap, $attached_deviceid, $running) = @_;
-
+sub qemu_volume_snapshot_delete($vmid, $storecfg, $drive, $snap, $attached_deviceid, $running) {
my $volid = $drive->{file};
my $do_snapshots_type = do_snapshots_type($storecfg, $drive, $attached_deviceid, $running);
--
2.47.3
next prev parent reply other threads:[~2026-09-25 12:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 12:26 [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 1/7] volume snapshot (delete): avoid using deprecated check_running() helper Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 2/7] volume snapshot delete: move getting attached device ID to caller Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 3/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 4/7] snapshot: add module for snapshot-related functionality Fiona Ebner
2026-09-25 12:26 ` Fiona Ebner [this message]
2026-09-25 12:26 ` [PATCH qemu-server 6/7] volume chain: blockdev delete: remove superfluous parse_volume_id() call Fiona Ebner
2026-09-25 12:26 ` [PATCH qemu-server 7/7] volume chain: blockdev delete: pass volume ID instead of drive and mark private Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925122646.139215-6-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox