Re: [PATCH-SERIES qemu-server v2 0/2] hotplug pending: use machine type from running instance to avoid mismatch

[Dominik Csapak <d.csapak@proxmox.com>]

aside from one nit on patch 2/2 LGTM
tested by hotplugging some random devices (nics/disks) on
a machine with no pinned machine version. all seemed to work

so consider this:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 10/6/26 10:59 AM, Fiona Ebner wrote:
> Changes in v2:
> * add second patch with optimization to only query machine type when
>    actually required.
> 
> The machine version from the configuration might be using the 'latest'
> version, in which case the currently running machine version might be
> different from the version of the installed QEMU binary. This is an
> issue, because sub-calls of vmconfig_hotplug_pending() like
> print_drivedevice_full() use the binary version as a fallback when
> there is an unresolved 'latest' version. Hotplug needs to respect the
> current running machine version for migration compatibility.
> 
> qemu-server:
> 
> Fiona Ebner (2):
>    hotplug pending: use machine type from running instance to avoid
>      mismatch
>    hotplug pending: only query machine type when actually required
> 
>   src/PVE/QemuServer.pm | 26 ++++++++++++++++----------
>   1 file changed, 16 insertions(+), 10 deletions(-)
> 
> 
> Summary over all repositories:
>    1 files changed, 16 insertions(+), 10 deletions(-)
>