From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 05AB61FF0AA for ; Tue, 06 Oct 2026 14:17:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6BC98213C3; Tue, 06 Oct 2026 14:17:05 +0200 (CEST) Message-ID: <32c301ec-e4b5-4692-99f7-cbedf6675416@proxmox.com> Date: Tue, 6 Oct 2026 14:17:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH-SERIES qemu-server v2 0/2] hotplug pending: use machine type from running instance to avoid mismatch To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20261006085936.30542-1-f.ebner@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20261006085936.30542-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791289020734 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.388 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AQ3U2HU74HD2R7I4UVCO3XPNZMLYEN6A X-Message-ID-Hash: AQ3U2HU74HD2R7I4UVCO3XPNZMLYEN6A X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: aside from one nit on patch 2/2 LGTM tested by hotplugging some random devices (nics/disks) on a machine with no pinned machine version. all seemed to work so consider this: Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 10/6/26 10:59 AM, Fiona Ebner wrote: > Changes in v2: > * add second patch with optimization to only query machine type when > actually required. > > The machine version from the configuration might be using the 'latest' > version, in which case the currently running machine version might be > different from the version of the installed QEMU binary. This is an > issue, because sub-calls of vmconfig_hotplug_pending() like > print_drivedevice_full() use the binary version as a fallback when > there is an unresolved 'latest' version. Hotplug needs to respect the > current running machine version for migration compatibility. > > qemu-server: > > Fiona Ebner (2): > hotplug pending: use machine type from running instance to avoid > mismatch > hotplug pending: only query machine type when actually required > > src/PVE/QemuServer.pm | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > > > Summary over all repositories: > 1 files changed, 16 insertions(+), 10 deletions(-) >