Re: [PATCH pve-network v4 32/47] sdn: change detection for route maps / prefix lists

[Hannes Laimer <h.laimer@proxmox.com>]

On 2026-05-04 18:04, Stefan Hanreich wrote:
> Add both configuration files to the has_pending_changes function, in
> order to detect changes to the global SDN configuration. Additionally,
> some new keys that are not primitive types have been introduced in the
> route-maps.cfg and prefix-lists.cfg. Add them to the function that
> generates the pending changes in the SDN stack, so we can return them
> from the respective endpoints.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/Network/SDN.pm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
> index 0bb36bf..ab97a59 100644
> --- a/src/PVE/Network/SDN.pm
> +++ b/src/PVE/Network/SDN.pm
> @@ -241,6 +241,8 @@ sub has_pending_changes {
>          vnets => PVE::Network::SDN::Vnets::config(),
>          subnets => PVE::Network::SDN::Subnets::config(),
>          controllers => PVE::Network::SDN::Controllers::config(),
> +        'route-maps' => PVE::Network::SDN::RouteMaps::config(),
> +        'prefix-lists' => PVE::Network::SDN::PrefixLists::config(),


we need `->to_sections()` for these two, perlmod returns a blessed but
empty hash, so once route-maps or prefix-lists exist in the running
config change detection sees them all as deleted


could reproduce this with:
```
pvesh create /cluster/sdn/prefix-lists --id reprolist --entries
'action=permit,prefix=192.0.2.0/24'

pvesh set /cluster/sdn

pvesh create /cluster/sdn/lock
> could not acquire lock for SDN config: configuration has pending
changes at /usr/share/perl5/PVE/API2/Network/SDN.pm line 164.
```

>      };
>  
>      for my $config_file (keys %$config_files) {
> @@ -484,7 +486,15 @@ sub generate_dhcp_config {
>  sub encode_value {
>      my ($type, $key, $value) = @_;
>  
> -    if ($key eq 'nodes' || $key eq 'exitnodes' || $key eq 'dhcp-range' || $key eq 'interfaces') {
> +    if (
> +        $key eq 'nodes'
> +        || $key eq 'exitnodes'
> +        || $key eq 'dhcp-range'
> +        || $key eq 'interfaces'
> +        || $key eq 'entries'
> +        || $key eq 'match'
> +        || $key eq 'set'
> +    ) {
>          if (ref($value) eq 'HASH') {
>              return join(',', sort keys(%$value));
>          } elsif (ref($value) eq 'ARRAY') {