From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E668C1FF141 for ; Tue, 05 May 2026 11:08:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE24720220; Tue, 5 May 2026 11:08:32 +0200 (CEST) Message-ID: <2699f5da-35e9-4965-b031-7899d5cb9d93@proxmox.com> Date: Tue, 5 May 2026 11:07:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH pve-network v4 32/47] sdn: change detection for route maps / prefix lists To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260504160350.395470-1-s.hanreich@proxmox.com> <20260504160350.395470-33-s.hanreich@proxmox.com> From: Hannes Laimer Content-Language: en-US In-Reply-To: <20260504160350.395470-33-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777971969428 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.570 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLACK 3 Contains an URL listed in the URIBL blacklist [sdn.pm] Message-ID-Hash: A5VXY5NEOIV5E7Q4YRXHJ4DJQF3TZDNI X-Message-ID-Hash: A5VXY5NEOIV5E7Q4YRXHJ4DJQF3TZDNI X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-05-04 18:04, Stefan Hanreich wrote: > Add both configuration files to the has_pending_changes function, in > order to detect changes to the global SDN configuration. Additionally, > some new keys that are not primitive types have been introduced in the > route-maps.cfg and prefix-lists.cfg. Add them to the function that > generates the pending changes in the SDN stack, so we can return them > from the respective endpoints. > > Signed-off-by: Stefan Hanreich > --- > src/PVE/Network/SDN.pm | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm > index 0bb36bf..ab97a59 100644 > --- a/src/PVE/Network/SDN.pm > +++ b/src/PVE/Network/SDN.pm > @@ -241,6 +241,8 @@ sub has_pending_changes { > vnets => PVE::Network::SDN::Vnets::config(), > subnets => PVE::Network::SDN::Subnets::config(), > controllers => PVE::Network::SDN::Controllers::config(), > + 'route-maps' => PVE::Network::SDN::RouteMaps::config(), > + 'prefix-lists' => PVE::Network::SDN::PrefixLists::config(), we need `->to_sections()` for these two, perlmod returns a blessed but empty hash, so once route-maps or prefix-lists exist in the running config change detection sees them all as deleted could reproduce this with: ``` pvesh create /cluster/sdn/prefix-lists --id reprolist --entries 'action=permit,prefix=192.0.2.0/24' pvesh set /cluster/sdn pvesh create /cluster/sdn/lock > could not acquire lock for SDN config: configuration has pending changes at /usr/share/perl5/PVE/API2/Network/SDN.pm line 164. ``` > }; > > for my $config_file (keys %$config_files) { > @@ -484,7 +486,15 @@ sub generate_dhcp_config { > sub encode_value { > my ($type, $key, $value) = @_; > > - if ($key eq 'nodes' || $key eq 'exitnodes' || $key eq 'dhcp-range' || $key eq 'interfaces') { > + if ( > + $key eq 'nodes' > + || $key eq 'exitnodes' > + || $key eq 'dhcp-range' > + || $key eq 'interfaces' > + || $key eq 'entries' > + || $key eq 'match' > + || $key eq 'set' > + ) { > if (ref($value) eq 'HASH') { > return join(',', sort keys(%$value)); > } elsif (ref($value) eq 'ARRAY') {