public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler
@ 2026-04-21  8:05 Nicolas Frey
  2026-04-22  6:24 ` Kefu Chai
  2026-04-22  7:55 ` superseded: " Nicolas Frey
  0 siblings, 2 replies; 4+ messages in thread
From: Nicolas Frey @ 2026-04-21  8:05 UTC (permalink / raw)
  To: pve-devel

Suggested-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 pveceph.adoc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pveceph.adoc b/pveceph.adoc
index 2aae6d6..dfa5d95 100644
--- a/pveceph.adoc
+++ b/pveceph.adoc
@@ -916,6 +916,9 @@ TIP: If the pool already contains objects, these must be moved accordingly.
 Depending on your setup, this may introduce a big performance impact on your
 cluster. As an alternative, you can create a new pool and move disks separately.

+WARNING: When using the autoscaler, all pools must either exclusively be assigned
+device-specific or device-unspecific CRUSH rules. Mixing them across pools will
+prevent the autoscaler from functioning.

 Ceph Client
 -----------
--
2.47.3



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler
  2026-04-21  8:05 [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler Nicolas Frey
@ 2026-04-22  6:24 ` Kefu Chai
  2026-04-22  7:30   ` Nicolas Frey
  2026-04-22  7:55 ` superseded: " Nicolas Frey
  1 sibling, 1 reply; 4+ messages in thread
From: Kefu Chai @ 2026-04-22  6:24 UTC (permalink / raw)
  To: Nicolas Frey, pve-devel

Nicolas Frey <n.frey@proxmox.com> writes:

Hi Nicolas, thanks for this improvement. A few nits:

> Suggested-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  pveceph.adoc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/pveceph.adoc b/pveceph.adoc
> index 2aae6d6..dfa5d95 100644
> --- a/pveceph.adoc
> +++ b/pveceph.adoc
> @@ -916,6 +916,9 @@ TIP: If the pool already contains objects, these must be moved accordingly.
>  Depending on your setup, this may introduce a big performance impact on your
>  cluster. As an alternative, you can create a new pool and move disks separately.
>
> +WARNING: When using the autoscaler, all pools must either exclusively be assigned
> +device-specific or device-unspecific CRUSH rules. Mixing them across pools will
>

device-specific / device-unspecific is not Ceph's terminology. Ceph's
terms are "CRUSH rules that specify a device class", or simply "device
class rules".

> +prevent the autoscaler from functioning.

this might overstates the problem caused by overlapped roots. The
autoscaler keeps running: it just skips pools whose CRUSH rules's OSD
sets overlap, and the pg_num is not adjustted for those pools. In other
words, non-overlapping pools continue to scale.

So, probably we can be more specific here? like:

When using the PG autoscaler, all pools in the cluster must use
CRUSH rules of the same kind, either all specifying a device class,
or all without one. Otherwise the autoscaler will skip the affected
pools and their `pg_num` will not be adjusted.

what do you think?

>
>  Ceph Client
>  -----------
> --
> 2.47.3




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler
  2026-04-22  6:24 ` Kefu Chai
@ 2026-04-22  7:30   ` Nicolas Frey
  0 siblings, 0 replies; 4+ messages in thread
From: Nicolas Frey @ 2026-04-22  7:30 UTC (permalink / raw)
  To: pve-devel

On 4/22/26 8:23 AM, Kefu Chai wrote:
> Nicolas Frey <n.frey@proxmox.com> writes:
> 
> Hi Nicolas, thanks for this improvement. A few nits:
> 
>> Suggested-by: Friedrich Weber <f.weber@proxmox.com>
>> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
>> ---
>>  pveceph.adoc | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/pveceph.adoc b/pveceph.adoc
>> index 2aae6d6..dfa5d95 100644
>> --- a/pveceph.adoc
>> +++ b/pveceph.adoc
>> @@ -916,6 +916,9 @@ TIP: If the pool already contains objects, these must be moved accordingly.
>>  Depending on your setup, this may introduce a big performance impact on your
>>  cluster. As an alternative, you can create a new pool and move disks separately.
>>
>> +WARNING: When using the autoscaler, all pools must either exclusively be assigned
>> +device-specific or device-unspecific CRUSH rules. Mixing them across pools will
>>
> 
> device-specific / device-unspecific is not Ceph's terminology. Ceph's
> terms are "CRUSH rules that specify a device class", or simply "device
> class rules".
> 

Thanks! I was not aware of the terminology used by ceph here

>> +prevent the autoscaler from functioning.
> 
> this might overstates the problem caused by overlapped roots. The
> autoscaler keeps running: it just skips pools whose CRUSH rules's OSD
> sets overlap, and the pg_num is not adjustted for those pools. In other
> words, non-overlapping pools continue to scale.

Ah, thanks for the explanation!

> 
> So, probably we can be more specific here? like:
> 
> When using the PG autoscaler, all pools in the cluster must use
> CRUSH rules of the same kind, either all specifying a device class,
> or all without one. Otherwise the autoscaler will skip the affected
> pools and their `pg_num` will not be adjusted.
> 
> what do you think?
> 

That sounds great! I'll send a v2 with your suggestions

>>
>>  Ceph Client
>>  -----------
>> --
>> 2.47.3





^ permalink raw reply	[flat|nested] 4+ messages in thread

* superseded: [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler
  2026-04-21  8:05 [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler Nicolas Frey
  2026-04-22  6:24 ` Kefu Chai
@ 2026-04-22  7:55 ` Nicolas Frey
  1 sibling, 0 replies; 4+ messages in thread
From: Nicolas Frey @ 2026-04-22  7:55 UTC (permalink / raw)
  To: pve-devel

superseded-by:https://lore.proxmox.com/pve-devel/20260422075440.20996-1-n.frey@proxmox.com/T/#u




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-22  7:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-21  8:05 [PATCH pve-docs 1/1] ceph: add warning about mixing device-specific with device-unspecific CRUSH rules when using autoscaler Nicolas Frey
2026-04-22  6:24 ` Kefu Chai
2026-04-22  7:30   ` Nicolas Frey
2026-04-22  7:55 ` superseded: " Nicolas Frey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal