From: Fiona Ebner <f.ebner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH storage v3 1/2] nfs: create a helper to run rpcinfo commands
Date: Mon, 6 Jul 2026 15:01:36 +0200 [thread overview]
Message-ID: <24a93317-e153-4bff-a203-bef74d65afb7@proxmox.com> (raw)
In-Reply-To: <20260325124646.298999-2-m.sandoval@proxmox.com>
commit title nit: the helper does not run the commands
Am 25.03.26 um 1:46 PM schrieb Maximiliano Sandoval:
> Will be used in the next command as a fallback in the case where opts
Nit: "Will also be used" since this commit introduces a usage already
Typo: s/command/commit/
> vers=4 is not used.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
With better commit title/message:
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2026-07-06 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 12:46 [PATCH storage v3 0/2] nfs: use rpcinfo as a showmounts fallback for nfs3 Maximiliano Sandoval
2026-03-25 12:46 ` [PATCH storage v3 1/2] nfs: create a helper to run rpcinfo commands Maximiliano Sandoval
2026-07-06 13:01 ` Fiona Ebner [this message]
2026-03-25 12:46 ` [PATCH storage v3 2/2] nfs: use rpcinfo as a showmounts fallback for nfs3 Maximiliano Sandoval
2026-07-06 13:01 ` Fiona Ebner
2026-07-06 14:19 ` Maximiliano Sandoval
2026-07-06 14:38 ` superseded: [PATCH storage v3 0/2] " Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a93317-e153-4bff-a203-bef74d65afb7@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox