From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 8893C1FF150
	for <inbox@lore.proxmox.com>; Mon, 06 Jul 2026 15:02:15 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 09A9B21453;
	Mon, 06 Jul 2026 15:02:15 +0200 (CEST)
Message-ID: <24a93317-e153-4bff-a203-bef74d65afb7@proxmox.com>
Date: Mon, 6 Jul 2026 15:01:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH storage v3 1/2] nfs: create a helper to run rpcinfo
 commands
To: Maximiliano Sandoval <m.sandoval@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260325124646.298999-1-m.sandoval@proxmox.com>
 <20260325124646.298999-2-m.sandoval@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260325124646.298999-2-m.sandoval@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783342895223
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.042 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 23D3MDNC2S6JZRRTKCSRPI27M4LVAXM3
X-Message-ID-Hash: 23D3MDNC2S6JZRRTKCSRPI27M4LVAXM3
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

commit title nit: the helper does not run the commands

Am 25.03.26 um 1:46 PM schrieb Maximiliano Sandoval:
> Will be used in the next command as a fallback in the case where opts

Nit: "Will also be used" since this commit introduces a usage already

Typo: s/command/commit/

> vers=4 is not used.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>

With better commit title/message:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>