* [PATCH qemu-server] fix #7480: api: apply tag case-sensitivity setting on VM creation
@ 2026-05-22 14:42 Jakob Klocker
2026-06-09 12:11 ` David Riley
0 siblings, 1 reply; 2+ messages in thread
From: Jakob Klocker @ 2026-05-22 14:42 UTC (permalink / raw)
To: pve-devel; +Cc: Jakob Klocker
The case-sensitivity setting from datacenter.cfg was not checked
when tags were set during VM creation. Tags containing capital
letters were stored verbatim, while the same tags applied later
via the update endpoint were normalized. This led to inconsistent
behavior depending on whether a tag was set at creation or
afterwards.
Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7480
Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
---
src/PVE/API2/Qemu.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index e029a204..dd813e8a 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -1500,6 +1500,10 @@ __PACKAGE__->register_method({
$conf->{lock} = 'import' if $live_import_mapping;
+ if (defined $conf->{tags}) {
+ $conf->{tags} = PVE::GuestHelpers::get_unique_tags($conf->{tags});
+ }
+
PVE::QemuConfig->write_config($vmid, $conf);
};
my $err = $@;
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH qemu-server] fix #7480: api: apply tag case-sensitivity setting on VM creation
2026-05-22 14:42 [PATCH qemu-server] fix #7480: api: apply tag case-sensitivity setting on VM creation Jakob Klocker
@ 2026-06-09 12:11 ` David Riley
0 siblings, 0 replies; 2+ messages in thread
From: David Riley @ 2026-06-09 12:11 UTC (permalink / raw)
To: Jakob Klocker, pve-devel
Thanks for sending in this patch.
I was able to reproduce the issue using the commands from the bugzilla
report [0] for VMs. I was also unable to reproduce the issue for
LXCs as described in [0].
I used these commands to reproduce the error for VMs:
qm create 130 --name tagtest --tags "cAsE-iNsEnSiTiVe"
qm set 130 --tags "cAsE-iNsEnSiTiVe"
And tested LXCs using this command:
pct create 101 local:vztmpl/debian-13-standard_13.1-2_amd64.tar.zst \
--storage local-zfs --hostname test --nameserver 172.16.99.1 \
--tags "case-Sensitive"
After applying the patch, case sensitivity works as expected on the
commandline as well as the WebUI.
I also tested this with the case-sensitive flag set
("Datacenter" -> "Options" -> "Tag Style Override"). Everything
worked as expected. Tags were now case-sensitive on creation but also
when setting them afterwards.
Consider this as
Tested-by: David Riley <d.riley@proxmox.com>
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=7480
On 5/22/26 4:42 PM, Jakob Klocker wrote:
> The case-sensitivity setting from datacenter.cfg was not checked
> when tags were set during VM creation. Tags containing capital
>
> [...]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-09 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 14:42 [PATCH qemu-server] fix #7480: api: apply tag case-sensitivity setting on VM creation Jakob Klocker
2026-06-09 12:11 ` David Riley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox