public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Kaiyang Wu <wukaiyang2003@gmail.com>, pve-devel@lists.proxmox.com
Cc: Kaiyang Wu <wukaiyang@loongfans.cn>
Subject: Re: [PATCH qemu-server/docs/manager/ha-manager 0/5] add pvpanic device support
Date: Tue, 22 Sep 2026 13:38:40 +0200	[thread overview]
Message-ID: <2082cf35-6e18-472f-ad33-a1629a482d69@proxmox.com> (raw)
In-Reply-To: <20260914092015.125780-1-wukaiyang@loongfans.cn>

ok most code looks good to me, but I seemingly didn't properly
explained last time what i meant with ha integration:

instead of letting Ha parse the guest state and act accordingly
my suggestion was more to let the user configure
the '-action panic=XX' commandline too

there one can e.g. set 'exit-failure' which exits the qemu
process completely and ha would automatically notice it's down
during the next round and start it again, no need
to touch the ha code at all

On 9/14/26 11:20 AM, Kaiyang Wu wrote:
> This patchset adds pvpanic device support to QEMU virtual machines to
> provide extra virtual machine status (guest-panicked) when virtual
> machines panic [0]. The HA stack now restarts a "started" VM when it
> panics.
> 
> [0]: https://www.qemu.org/docs/master/specs/pvpanic.html
> 
> v1: https://lore.proxmox.com/pve-devel/20260827103529.393388-1-wukaiyang@loongfans.cn/
> 
> Changes v1 -> v2:
> - Remove the pvpanic ISA device support to simplify the code
> - Move the pvpanic setting from Hardware to Options
> - Restart a HA-managed VM when it panics to restore the "started" state
> 
> 
> qemu-server:
> 
> Kaiyang Wu (1):
>    qemuserver: add pvpanic device
> 
>   src/PVE/API2/Qemu.pm      |  1 +
>   src/PVE/QemuServer.pm     | 11 +++++++++++
>   src/PVE/QemuServer/PCI.pm |  1 +
>   3 files changed, 13 insertions(+)
> 
> 
> docs:
> 
> Kaiyang Wu (1):
>    qm: add document section for the pvpanic device
> 
>   qm.adoc | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> 
> manager:
> 
> Kaiyang Wu (1):
>    ui: qemu: add pvpanic device support
> 
>   www/manager6/qemu/Options.js | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> 
> ha-manager:
> 
> Kaiyang Wu (2):
>    vm resource: return running status -1 for panicked VMs
>    lrm: stop and restart panicked VMs to keep the "started" state
> 
>   src/PVE/HA/LRM.pm             | 9 ++++++++-
>   src/PVE/HA/Resources/PVEVM.pm | 5 ++++-
>   2 files changed, 12 insertions(+), 2 deletions(-)
> 





      parent reply	other threads:[~2026-09-22 11:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  9:20 [PATCH qemu-server/docs/manager/ha-manager 0/5] add pvpanic device support Kaiyang Wu
2026-09-14  9:20 ` [PATCH qemu-server 1/5] qemuserver: add pvpanic device Kaiyang Wu
2026-09-14  9:20 ` [PATCH docs 2/5] qm: add document section for the " Kaiyang Wu
2026-09-14  9:20 ` [PATCH manager 3/5] ui: qemu: add pvpanic device support Kaiyang Wu
2026-09-14  9:20 ` [PATCH ha-manager 4/5] vm resource: return running status -1 for panicked VMs Kaiyang Wu
2026-09-14  9:20 ` [PATCH ha-manager 5/5] lrm: stop and restart panicked VMs to keep the "started" state Kaiyang Wu
2026-09-22  9:14 ` [PATCH qemu-server/docs/manager/ha-manager 0/5] add pvpanic device support Kaiyang Wu
2026-09-22 11:07   ` Dominik Csapak
2026-09-22 11:38 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2082cf35-6e18-472f-ad33-a1629a482d69@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=wukaiyang2003@gmail.com \
    --cc=wukaiyang@loongfans.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal