From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 84F351FF0AA for ; Tue, 22 Sep 2026 13:38:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 41263214DD; Tue, 22 Sep 2026 13:38:45 +0200 (CEST) Message-ID: <2082cf35-6e18-472f-ad33-a1629a482d69@proxmox.com> Date: Tue, 22 Sep 2026 13:38:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server/docs/manager/ha-manager 0/5] add pvpanic device support To: Kaiyang Wu , pve-devel@lists.proxmox.com References: <20260914092015.125780-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20260914092015.125780-1-wukaiyang@loongfans.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790077120454 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.456 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QI5X3JVLJO4ZPQGCPIAET7UHKDTHYWSB X-Message-ID-Hash: QI5X3JVLJO4ZPQGCPIAET7UHKDTHYWSB X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ok most code looks good to me, but I seemingly didn't properly explained last time what i meant with ha integration: instead of letting Ha parse the guest state and act accordingly my suggestion was more to let the user configure the '-action panic=XX' commandline too there one can e.g. set 'exit-failure' which exits the qemu process completely and ha would automatically notice it's down during the next round and start it again, no need to touch the ha code at all On 9/14/26 11:20 AM, Kaiyang Wu wrote: > This patchset adds pvpanic device support to QEMU virtual machines to > provide extra virtual machine status (guest-panicked) when virtual > machines panic [0]. The HA stack now restarts a "started" VM when it > panics. > > [0]: https://www.qemu.org/docs/master/specs/pvpanic.html > > v1: https://lore.proxmox.com/pve-devel/20260827103529.393388-1-wukaiyang@loongfans.cn/ > > Changes v1 -> v2: > - Remove the pvpanic ISA device support to simplify the code > - Move the pvpanic setting from Hardware to Options > - Restart a HA-managed VM when it panics to restore the "started" state > > > qemu-server: > > Kaiyang Wu (1): > qemuserver: add pvpanic device > > src/PVE/API2/Qemu.pm | 1 + > src/PVE/QemuServer.pm | 11 +++++++++++ > src/PVE/QemuServer/PCI.pm | 1 + > 3 files changed, 13 insertions(+) > > > docs: > > Kaiyang Wu (1): > qm: add document section for the pvpanic device > > qm.adoc | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > > manager: > > Kaiyang Wu (1): > ui: qemu: add pvpanic device support > > www/manager6/qemu/Options.js | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > > ha-manager: > > Kaiyang Wu (2): > vm resource: return running status -1 for panicked VMs > lrm: stop and restart panicked VMs to keep the "started" state > > src/PVE/HA/LRM.pm | 9 ++++++++- > src/PVE/HA/Resources/PVEVM.pm | 5 ++++- > 2 files changed, 12 insertions(+), 2 deletions(-) >