public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH storage 0/2] rbd: avoid hanging VM start on EFI disk cache policy
@ 2026-11-20 14:10 Jonas Theisen
  2026-11-20 14:10 ` [PATCH storage 1/2] rbd: only set image config if the value differs Jonas Theisen
  2026-11-20 14:10 ` [PATCH storage 2/2] rbd: do not let setting the EFI disk cache policy block VM start Jonas Theisen
  0 siblings, 2 replies; 3+ messages in thread
From: Jonas Theisen @ 2026-11-20 14:10 UTC (permalink / raw)
  To: pve-devel

Starting a VM with an EFI disk on RBD sets the rbd_cache_policy image
config on every start. On the target of a live migration, the source
VM still holds the exclusive lock, so librbd forwards the write to it
and re-sends the request every 30 seconds until the lock owner reports
completion. 'rbd config image set' then hangs without end if:

- the lock owner never reports completion, or
- the completion arrives just after a re-send timed out, but before
  the request is sent again. The requester drops it, and the lock
  owner answers every further re-send of the finished request with its
  result, 0 on success. That is the same answer as for a request still
  in progress, so the requester waits for a completion that is never
  sent again. See prepare_async_request() in librbd's ImageWatcher.cc.

The VM start on the target, and thus the migration, then hangs until
the rbd process is killed.

Patch 1 reads the current value first and only writes it if it
differs. Reading the image config does not involve the lock owner, and
after the first start the value is already set, so migrations no
longer depend on the lock owner in the common case.

This reverses the choice made in commit 590fb762 ("plugin: qemu block
device: add hints option and EFI disk hint"), which deliberately set
the value unconditionally: querying it was considered to only add
cost, and 'rbd config image get' fails if the key has not been set
yet. The extra read is one cheap command per VM start with an EFI disk
on RBD, which is a small price for not hanging the migration. The
failing 'get' on an unset key is handled by treating any error as "not
set" and falling back to writing the value, as before.

Patch 2 covers the remaining case, where the value does need to be
written while another client holds the lock: the write is aborted
after 60 seconds, which allows for one retry of the remote request,
and a failure only results in a warning. The cache policy only affects
the performance of EFI variable writes, so it should not fail the VM
start, and thus the migration.

In the best case we would not need this because the rbd command never
hangs, but there have been cases in Enterprise Support where this
exact failure mode blocked migrations.

Jonas Theisen (2):
  rbd: only set image config if the value differs
  rbd: do not let setting the EFI disk cache policy block VM start

 src/PVE/Storage/RBDPlugin.pm | 31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

-- 
2.47.3





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20 14:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 14:10 [PATCH storage 0/2] rbd: avoid hanging VM start on EFI disk cache policy Jonas Theisen
2026-11-20 14:10 ` [PATCH storage 1/2] rbd: only set image config if the value differs Jonas Theisen
2026-11-20 14:10 ` [PATCH storage 2/2] rbd: do not let setting the EFI disk cache policy block VM start Jonas Theisen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal