From: Lukas Sichert <l.sichert@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Lukas Sichert <l.sichert@proxmox.com>
Subject: [PATCH docs/manager/storage 0/4] fix #8196: lvm: add a throughput limit for discards
Date: Fri, 20 Nov 2026 14:32:39 +0100 [thread overview]
Message-ID: <20261120133245.51042-1-l.sichert@proxmox.com> (raw)
Unthrottled discards can overload the controllers of enterprise storage
arrays. The cleanup worker discards removed volumes in bounded batches
that share the loop pacing the saferemove writes, so limiting the rate
there throttles discards too.
This series adds a 'discard_throughput' option to 'on-volume-remove'. It
takes the same values as 'saferemove_throughput'. If both are set while
wiping, the lower limit is used, since both go through the same pacing
loop. Not setting the option, or setting it to zero, means no limit from
this option.
The option only has an effect if 'discard' is enabled. It can be set
through the API or CLI. The storage edit dialog has no field for it, but
saving the dialog no longer drops it.
Link: https://bugzilla.proxmox.com/show_bug.cgi?id=8196
storage:
Lukas Sichert (2):
lvm: rename the saferemove throughput parser to parse_throughput
fix #8196: lvm: add discard throughput limit
src/PVE/Storage/LVMPlugin.pm | 30 +++++++++++++++++-----
src/test/run_test_lvm_throughput.pl | 40 +++++++++++++++++++++++++++++
2 files changed, 64 insertions(+), 6 deletions(-)
manager:
Lukas Sichert (1):
ui: lvm: keep other on-volume-remove options when editing
www/manager6/storage/LVMEdit.js | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
docs:
Lukas Sichert (1):
storage: lvm: document the discard throughput limit
pve-storage-lvm.adoc | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Summary over all repositories:
4 files changed, 74 insertions(+), 8 deletions(-)
--
Generated by murpp 0.12.0
next reply other threads:[~2026-11-20 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 13:32 Lukas Sichert [this message]
2026-11-20 13:32 ` [PATCH storage 1/4] lvm: rename the saferemove throughput parser to parse_throughput Lukas Sichert
2026-11-20 13:32 ` [PATCH storage 2/4] fix #8196: lvm: add discard throughput limit Lukas Sichert
2026-11-20 13:32 ` [PATCH manager 3/4] ui: lvm: keep other on-volume-remove options when editing Lukas Sichert
2026-11-20 13:32 ` [PATCH docs 4/4] storage: lvm: document the discard throughput limit Lukas Sichert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261120133245.51042-1-l.sichert@proxmox.com \
--to=l.sichert@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox