From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 717921FF0AF for ; Fri, 20 Nov 2026 14:32:58 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F0D6B21731; Fri, 20 Nov 2026 14:32:55 +0100 (CET) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH docs/manager/storage 0/4] fix #8196: lvm: add a throughput limit for discards Date: Fri, 20 Nov 2026 14:32:39 +0100 Message-ID: <20261120133245.51042-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795181571395 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.454 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZFJOKDOQPMJOLUBRUKBVIG3CFYON4TK3 X-Message-ID-Hash: ZFJOKDOQPMJOLUBRUKBVIG3CFYON4TK3 X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Unthrottled discards can overload the controllers of enterprise storage arrays. The cleanup worker discards removed volumes in bounded batches that share the loop pacing the saferemove writes, so limiting the rate there throttles discards too. This series adds a 'discard_throughput' option to 'on-volume-remove'. It takes the same values as 'saferemove_throughput'. If both are set while wiping, the lower limit is used, since both go through the same pacing loop. Not setting the option, or setting it to zero, means no limit from this option. The option only has an effect if 'discard' is enabled. It can be set through the API or CLI. The storage edit dialog has no field for it, but saving the dialog no longer drops it. Link: https://bugzilla.proxmox.com/show_bug.cgi?id=8196 storage: Lukas Sichert (2): lvm: rename the saferemove throughput parser to parse_throughput fix #8196: lvm: add discard throughput limit src/PVE/Storage/LVMPlugin.pm | 30 +++++++++++++++++----- src/test/run_test_lvm_throughput.pl | 40 +++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 6 deletions(-) manager: Lukas Sichert (1): ui: lvm: keep other on-volume-remove options when editing www/manager6/storage/LVMEdit.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) docs: Lukas Sichert (1): storage: lvm: document the discard throughput limit pve-storage-lvm.adoc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) Summary over all repositories: 4 files changed, 74 insertions(+), 8 deletions(-) -- Generated by murpp 0.12.0