public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v6 10/21] ui: qemu: introduce hardware disk grid
Date: Thu, 19 Nov 2026 10:28:23 +0100	[thread overview]
Message-ID: <20261119092930.830046-11-d.csapak@proxmox.com> (raw)
In-Reply-To: <20261119092930.830046-1-d.csapak@proxmox.com>

intended to be used inside the hardware view. not used yet.

The toolbar buttons will be added directly in the hardware view since
it requires accessing some data from there.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/Makefile                 |   1 +
 www/manager6/Utils.js                 |   7 +
 www/manager6/qemu/HardwareDiskGrid.js | 215 ++++++++++++++++++++++++++
 3 files changed, 223 insertions(+)
 create mode 100644 www/manager6/qemu/HardwareDiskGrid.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index 364f0883..dd33eb90 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -270,6 +270,7 @@ JSSRC= 							\
 	qemu/HDTPM.js					\
 	qemu/HDMove.js					\
 	qemu/HDResize.js				\
+	qemu/HardwareDiskGrid.js			\
 	qemu/HardwareView.js				\
 	qemu/IPConfigEdit.js				\
 	qemu/KeyboardEdit.js				\
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 42d3242a..49862c0f 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -2205,6 +2205,13 @@ Ext.define('PVE.Utils', {
             );
             return Ext.htmlEncode(description);
         },
+
+        renderBooleanProperty: function (value) {
+            if (Ext.isString(value)) {
+                value = PVE.Parser.parseBoolean(value);
+            }
+            return Proxmox.Utils.format_boolean(value);
+        },
     },
 
     singleton: true,
diff --git a/www/manager6/qemu/HardwareDiskGrid.js b/www/manager6/qemu/HardwareDiskGrid.js
new file mode 100644
index 00000000..912aa4fc
--- /dev/null
+++ b/www/manager6/qemu/HardwareDiskGrid.js
@@ -0,0 +1,215 @@
+Ext.define('PVE.qemu.HardwareDiskGrid', {
+    extend: 'PVE.grid.PendingGrid',
+    alias: 'widget.pveHardwareDiskGrid',
+
+    title: gettext('Hard Disks'),
+
+    stateful: true,
+    stateId: 'pve-qemu-hardware-disk',
+
+    border: false,
+    expandable: false,
+
+    minHeight: 100,
+    emptyText: gettext('No hard disks configured'),
+
+    recordParser: PVE.Parser.parseQemuDrive,
+    // override to render the keys properly
+    renderKey: Ext.htmlEncode,
+
+    columns: [
+        {
+            header: gettext('Bus/Device'),
+            dataIndex: 'id',
+            width: 150,
+            renderer: 'renderKey',
+        },
+        {
+            header: gettext('Volume/File'),
+            dataIndex: 'file',
+            flex: 1,
+            minWidth: 200,
+        },
+        {
+            header: gettext('Size'),
+            dataIndex: 'size',
+            width: 100,
+            renderer: (value) => {
+                if (value === undefined || value === null) {
+                    return '';
+                }
+
+                let size = value;
+                if (!size.toString().slice(-1).match(/[0-9]/)) {
+                    // IEC unit is implicit in config, but parser expects it as 'i' suffix
+                    size = `${value}i`;
+                }
+
+                return Proxmox.Utils.autoscale_size_unit(size);
+            },
+        },
+        {
+            header: gettext('Pre-Enrolled Keys (EFI Disk only)'),
+            dataIndex: 'pre-enrolled-keys',
+            renderer: (v, _md, rec, rI, cI, store, view, pending) => {
+                let iface = pending ? rec.data.pending?.interface : rec.data.interface;
+                if (iface !== 'efidisk') {
+                    return '';
+                }
+                if (PVE.Parser.parseBoolean(v)) {
+                    let msCerts = pending ? rec.data.pending?.['ms-cert'] : rec.data['ms-cert'];
+                    if (msCerts) {
+                        return `${gettext('Yes')} (MS Certificate: ${Ext.htmlEncode(msCerts)})`;
+                    } else {
+                        return gettext('Yes');
+                    }
+                } else {
+                    return gettext('No');
+                }
+            },
+        },
+        {
+            header: gettext('Cache'),
+            dataIndex: 'cache',
+            width: 140,
+            renderer: (v) =>
+                Ext.htmlEncode(v) ?? `${Proxmox.Utils.defaultText} (${gettext('No cache')})`,
+        },
+        {
+            header: gettext('Discard'),
+            dataIndex: 'discard',
+            width: 80,
+            renderer: PVE.Utils.renderBooleanProperty,
+        },
+        {
+            header: gettext('IO thread'),
+            dataIndex: 'iothread',
+            width: 100,
+            renderer: PVE.Utils.renderBooleanProperty,
+        },
+        {
+            header: gettext('SSD emulation'),
+            dataIndex: 'ssd',
+            width: 120,
+            renderer: PVE.Utils.renderBooleanProperty,
+        },
+        {
+            header: gettext('Backup'),
+            dataIndex: 'backup',
+            width: 80,
+            renderer: (v) => PVE.Utils.renderBooleanProperty(v ?? true),
+        },
+        {
+            header: gettext('Read-Only'),
+            dataIndex: 'ro',
+            width: 100,
+            renderer: PVE.Utils.renderBooleanProperty,
+        },
+        {
+            header: gettext('Replicate'),
+            dataIndex: 'replicate',
+            width: 100,
+            renderer: (v) => PVE.Utils.renderBooleanProperty(v ?? true),
+        },
+        {
+            header: gettext('Async I/O'),
+            dataIndex: 'aio',
+            width: 100,
+            renderer: (v) => Ext.htmlEncode(v) ?? `${Proxmox.Utils.defaultText} (io_uring)`,
+        },
+        {
+            header: gettext('Bandwidth Limits'),
+            hidden: true,
+            columns: [
+                {
+                    header: gettext('Read limit (MiB/s)'),
+                    dataIndex: 'mbps_rd',
+                    width: 120,
+                },
+                {
+                    header: gettext('Write limit (MiB/s)'),
+                    dataIndex: 'mbps_wr',
+                    width: 120,
+                },
+                {
+                    header: gettext('Read limit (ops/s)'),
+                    dataIndex: 'iops_rd',
+                    width: 120,
+                },
+                {
+                    header: gettext('Write limit (ops/s)'),
+                    dataIndex: 'iops_wr',
+                    width: 120,
+                },
+                {
+                    header: gettext('Read Burst (MiB/s)'),
+                    dataIndex: 'mbps_rd_max',
+                    width: 120,
+                },
+                {
+                    header: gettext('Write Burst (MiB/s)'),
+                    dataIndex: 'mbps_wr_max',
+                    width: 120,
+                },
+                {
+                    header: gettext('Read Burst (ops/s)'),
+                    dataIndex: 'iops_rd_max',
+                    width: 120,
+                },
+                {
+                    header: gettext('Write Burst (ops/s)'),
+                    dataIndex: 'iops_wr_max',
+                    width: 120,
+                },
+            ],
+        },
+        {
+            header: gettext('Detect Zeroes'),
+            dataIndex: 'detect_zeroes',
+            hidden: true,
+            renderer: (v) => PVE.Utils.renderBooleanProperty(v ?? true),
+        },
+        {
+            header: gettext('Vendor'),
+            dataIndex: 'vendor',
+            hidden: true,
+        },
+        {
+            header: gettext('Product'),
+            dataIndex: 'product',
+            hidden: true,
+        },
+        {
+            header: gettext('Serial'),
+            dataIndex: 'serial',
+            hidden: true,
+        },
+        {
+            header: gettext('Queues'),
+            dataIndex: 'queues',
+            hidden: true,
+        },
+        {
+            header: gettext('Shared'),
+            dataIndex: 'shared',
+            hidden: true,
+            renderer: PVE.Utils.renderBooleanProperty,
+        },
+        {
+            header: gettext('Write Error Action'),
+            dataIndex: 'werror',
+            hidden: true,
+        },
+        {
+            header: 'WWN',
+            dataIndex: 'wwn',
+            hidden: true,
+        },
+        {
+            header: gettext('Raw Config'),
+            dataIndex: 'raw',
+            hidden: true,
+            flex: 1,
+        },
+    ],
+});
-- 
2.47.3





  parent reply	other threads:[~2026-11-19  9:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:28 [PATCH pve-manager v6 00/21] ui: split out disks and nics into grids Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 01/21] ui: utils: factor out 'media=cdrom' check Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 02/21] ui: parser: qemu drive: allow '-' in key name Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 03/21] ui: qemu: network edit: remove unused 'networkmode' property Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 04/21] ui: parser: qemu network: allow unknown keys Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 05/21] ui: factor out the guest key nic regex check Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 06/21] ui: add pending grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 07/21] ui: revert button: add parentXType and reloadCallback Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 08/21] ui: button: add config remove button Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 09/21] ui: qemu: hardware: wrap in container Dominik Csapak
2026-11-19  9:28 ` Dominik Csapak [this message]
2026-11-19  9:28 ` [PATCH pve-manager v6 11/21] ui: qemu: introduce hardware net grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 12/21] ui: qemu: hardware view: separate disks into own grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 13/21] ui: qemu: hardware view: separate nics " Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 14/21] ui: qemu: hardware view: inline edit/remove/revert button in general grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 15/21] ui: qemu: hardware view: inline 'add efi' menuitem Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 16/21] ui: utils: factor out volume size renderer Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 17/21] ui: lxc: network view: convert to pending grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 18/21] ui: lxc: introduce resource volume grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 19/21] ui: lxc: resources: separate volumes into own grid Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 20/21] ui: lxc: resources: integrate network view Dominik Csapak
2026-11-19  9:28 ` [PATCH pve-manager v6 21/21] ui: qemu/lxc: volume/disk grid: add overflow handler Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119092930.830046-11-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal