From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v6 00/21] ui: split out disks and nics into grids
Date: Thu, 19 Nov 2026 10:28:13 +0100 [thread overview]
Message-ID: <20261119092930.830046-1-d.csapak@proxmox.com> (raw)
This splits the disks and nics of the qemu hardware view into their own
grids, where each option gets its own column (including pending
changes), instead of showing the raw config string in one big list.
New in this version is that the series does the same for containers:
the volumes (rootfs, mount points, unused disks) get their own grid in
the resource view, and the existing network view is converted to show
pending changes and then moved into the resource view too, so there is
no separate 'Network' panel for containers anymore.
For the container network view I tried to keep the existing behavior
and code where possible (it still shows the name and addresses from
inside the container), so that patch is hopefully easy to compare with
what we have now. It differs a bit from the qemu net grid in that it
keeps its own toolbar instead of the surrounding view handling the
buttons, since it had that before and it does not need anything from
the resource view.
I tried to keep most commits small so it's easier to see what the actual
changes are.
NOTE: I took special care for the button enablement logic, but having a
close look at that during review would make a lot of sense. That goes
for the new container patches as well.
Not addressed from the v4 feedback are the horizontal scrollbar topics
(overlapping the last row, toolbar not scrolling with the grid), since
those are not specific to this series.
changes from v5:
* new patch 3/21: remove unused 'networkmode' from qemu network edit
* new patch 4/21: parse and print unknown qemu nic options
* new patch 21/21: add overflow handler to disk/volume grid toolbars
* config remove button: don't throw for keys without a row definition
* qemu disk grid: rename 'Secure Boot' column to 'Pre-Enrolled Keys'
* qemu disk grid: show 'Detect Zeroes' as enabled when unset
* qemu disk grid: html-encode the ms-cert value
* qemu net grid: add hidden 'Raw Config' column
* lxc network view: disable 'Add' without VM.Config.Network
changes from v4:
* rebased on master
* new patches to do the same for containers (volumes and nics)
* re-added the parser patch for '-' in key names (reverted on master)
* pending grid: don't save sorters in the state
* pending grid: handle nested columns
* pending grid: mark the id of entries with pending changes
* pending grid: don't break on properties the parser does not know
* config remove button: make the waitMsgTarget configurable
* fix the remove button and the storage content selection mid-series
* disk grid: fix 'Secure Boot', 'Replicate' and 'Async I/O' columns
* net grid: fix the 'Disconnected' column
* make the hardware view scrollable
* fix sorting of the disk and net grids (e.g. unused disks)
* update the buttons when the selected entry changes on a reload
* fix the edit button in the general grid and for nics
* fix the 'Enroll Updated Certificates' button
* show 'Attach' for unused disks and don't allow reassigning tpmstate
changes from v3:
* rebased on master:
- dropped the parser patch (something similar was already applied)
- while moving to a container, the selection logic when coming from
a storage content panel had to be adapted.
changes from v2:
* reorganized code/commits for the most part, so it doesn't make much
sense to compare it to the previous version
changes from v1:
* refactor some regexes/checks
* fix some bugs I encountered during testing again
Dominik Csapak (21):
ui: utils: factor out 'media=cdrom' check
ui: parser: qemu drive: allow '-' in key name
ui: qemu: network edit: remove unused 'networkmode' property
ui: parser: qemu network: allow unknown keys
ui: factor out the guest key nic regex check
ui: add pending grid
ui: revert button: add parentXType and reloadCallback
ui: button: add config remove button
ui: qemu: hardware: wrap in container
ui: qemu: introduce hardware disk grid
ui: qemu: introduce hardware net grid
ui: qemu: hardware view: separate disks into own grid
ui: qemu: hardware view: separate nics into own grid
ui: qemu: hardware view: inline edit/remove/revert button in general
grid
ui: qemu: hardware view: inline 'add efi' menuitem
ui: utils: factor out volume size renderer
ui: lxc: network view: convert to pending grid
ui: lxc: introduce resource volume grid
ui: lxc: resources: separate volumes into own grid
ui: lxc: resources: integrate network view
ui: qemu/lxc: volume/disk grid: add overflow handler
www/manager6/Makefile | 5 +
www/manager6/Parser.js | 27 +-
www/manager6/Utils.js | 38 +-
www/manager6/button/ConfigRemove.js | 61 ++
www/manager6/button/Revert.js | 8 +-
www/manager6/grid/PendingGrid.js | 166 +++++
www/manager6/lxc/Config.js | 6 -
www/manager6/lxc/Network.js | 186 +++--
www/manager6/lxc/ResourceVolumeGrid.js | 96 +++
www/manager6/lxc/Resources.js | 557 ++++++++------
www/manager6/qemu/BootOrderEdit.js | 12 +-
www/manager6/qemu/CreateWizard.js | 4 +-
www/manager6/qemu/HardwareDiskGrid.js | 203 ++++++
www/manager6/qemu/HardwareNetGrid.js | 87 +++
www/manager6/qemu/HardwareView.js | 969 +++++++++++++++----------
www/manager6/qemu/NetworkEdit.js | 9 +-
www/manager6/window/GuestImport.js | 2 +-
17 files changed, 1714 insertions(+), 722 deletions(-)
create mode 100644 www/manager6/button/ConfigRemove.js
create mode 100644 www/manager6/grid/PendingGrid.js
create mode 100644 www/manager6/lxc/ResourceVolumeGrid.js
create mode 100644 www/manager6/qemu/HardwareDiskGrid.js
create mode 100644 www/manager6/qemu/HardwareNetGrid.js
--
2.47.3
next reply other threads:[~2026-11-19 9:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:28 Dominik Csapak [this message]
2026-11-19 9:28 ` [PATCH pve-manager v6 01/21] ui: utils: factor out 'media=cdrom' check Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 02/21] ui: parser: qemu drive: allow '-' in key name Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 03/21] ui: qemu: network edit: remove unused 'networkmode' property Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 04/21] ui: parser: qemu network: allow unknown keys Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 05/21] ui: factor out the guest key nic regex check Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 06/21] ui: add pending grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 07/21] ui: revert button: add parentXType and reloadCallback Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 08/21] ui: button: add config remove button Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 09/21] ui: qemu: hardware: wrap in container Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 10/21] ui: qemu: introduce hardware disk grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 11/21] ui: qemu: introduce hardware net grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 12/21] ui: qemu: hardware view: separate disks into own grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 13/21] ui: qemu: hardware view: separate nics " Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 14/21] ui: qemu: hardware view: inline edit/remove/revert button in general grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 15/21] ui: qemu: hardware view: inline 'add efi' menuitem Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 16/21] ui: utils: factor out volume size renderer Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 17/21] ui: lxc: network view: convert to pending grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 18/21] ui: lxc: introduce resource volume grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 19/21] ui: lxc: resources: separate volumes into own grid Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 20/21] ui: lxc: resources: integrate network view Dominik Csapak
2026-11-19 9:28 ` [PATCH pve-manager v6 21/21] ui: qemu/lxc: volume/disk grid: add overflow handler Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261119092930.830046-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox