public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH common v2 01/11] certificate tests: use q{} for multiline strings.
Date: Wed, 18 Nov 2026 11:31:15 +0100	[thread overview]
Message-ID: <20261118103127.165100-2-t.ellmenreich@proxmox.com> (raw)
In-Reply-To: <20261118103127.165100-1-t.ellmenreich@proxmox.com>

Instead of using EOF to define multiline strings in tests, use q{}. This
defines a clearer string boundary, specifically where newlines are.

Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
---
 test/check_pem_test.pl | 113 ++++++++++++++++++-----------------------
 test/split_pem_test.pl |  81 +++++++++++++----------------
 2 files changed, 86 insertions(+), 108 deletions(-)

diff --git a/test/check_pem_test.pl b/test/check_pem_test.pl
index 4917d2b..176194d 100755
--- a/test/check_pem_test.pl
+++ b/test/check_pem_test.pl
@@ -15,8 +15,7 @@ my $setup = [
     {
         expected_success => 1,
         name => "full pem",
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
 AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
 c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
@@ -27,14 +26,13 @@ MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
 Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
 SAAwRQIhANfakefakefakefakefakefakefakefakefake
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "other label pem",
         label => "SOME LABEL",
-        pem => <<'EOF',
------BEGIN SOME LABEL-----
+        pem => q{-----BEGIN SOME LABEL-----
 MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
 AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
 c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
@@ -45,102 +43,96 @@ MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
 Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
 SAAwRQIhANfakefakefakefakefakefakefakefakefake
 -----END SOME LABEL-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "simple pem",
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 test
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "spaced out pem",
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 
 test
 
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "only newline pem",
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "many newlines pem",
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 
 
 
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 0,
         name => "no content pem",
-        pem => <<'EOF',
+        pem => q{
 -----BEGIN CERTIFICATE----------END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "preceding content pem",
-        pem => <<'EOF',
+        pem => q{
 some extended content
 -----BEGIN CERTIFICATE-----
 test
 -----END CERTIFICATE-----
-EOF
+},
 
-        expected_result => <<'EOF',
------BEGIN CERTIFICATE-----
+        expected_result => q{-----BEGIN CERTIFICATE-----
 test
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 0,
         name => "following content pem",
-        pem => <<'EOF',
+        pem => q{
 -----BEGIN CERTIFICATE-----
 test
 -----END CERTIFICATE-----
 some extended content
-EOF
+},
     },
     {
         expected_success => 0,
         name => "empty pem",
-        pem => <<'EOF',
+        pem => q{
 
-EOF
+},
     },
     {
         expected_success => 0,
         name => "upsidedown pem",
-        pem => <<'EOF',
+        pem => q{
 -----END CERTIFICATE-----
 test
 -----BEGIN CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "multi pem",
         multiple => 1,
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 12JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
@@ -152,12 +144,12 @@ EOF
 -----BEGIN CERTIFICATE-----
 42JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 0,
         name => "multiple as single pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
@@ -174,13 +166,13 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "multiple pem",
         multiple => 1,
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
@@ -197,9 +189,8 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
-        expected_result => <<'EOF',
------BEGIN CERTIFICATE-----
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
 1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
 dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
@@ -211,14 +202,14 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "big pem different label",
         multiple => 1,
         label => "LABEL",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN LABEL-----
@@ -243,10 +234,9 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END LABEL-----
-EOF
+},
 
-        expected_result => <<'EOF',
------BEGIN LABEL-----
+        expected_result => q{-----BEGIN LABEL-----
 1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
 dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
@@ -264,12 +254,12 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END LABEL-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "other real pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
 Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
 -----BEGIN CERTIFICATE-----
@@ -278,20 +268,19 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
-        expected_result => <<'EOF',
------BEGIN CERTIFICATE-----
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
 1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
 dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 0,
         name => "invalid single pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
 Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
 -----BEGIN CERTIFICATE-----
@@ -300,13 +289,13 @@ dmFpdXdlYmdthese !?''*:;$%&/  are not allowedWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 0,
         name => "invalid multi pem",
         multiple => 1,
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
 Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
 -----BEGIN CERTIFICATE-----
@@ -324,26 +313,25 @@ dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
 
-EOF
+},
     },
     {
         expected_success => 1,
         name => "single as multiple pem",
         multiple => 1,
-        pem => <<'EOF',
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
 dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "single as multiple pem",
         multiple => 1,
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
 Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
 -----BEGIN CERTIFICATE-----
@@ -352,15 +340,14 @@ dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
-        expected_result => <<'EOF',
------BEGIN CERTIFICATE-----
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
 1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
 dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
 ];
 
diff --git a/test/split_pem_test.pl b/test/split_pem_test.pl
index 4239e5c..c4c79c4 100755
--- a/test/split_pem_test.pl
+++ b/test/split_pem_test.pl
@@ -15,7 +15,7 @@ my $setup = [
     {
         expected_success => 1,
         name => "single pem",
-        pem => <<'EOF',
+        pem => q{
 -----BEGIN CERTIFICATE-----
 MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
 AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
@@ -27,12 +27,12 @@ MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
 Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
 SAAwRQIhANfakefakefakefakefakefakefakefakefake
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "no extra text pem",
-        pem => <<'EOF',
+        pem => q{
 -----BEGIN CERTIFICATE-----
 12JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
@@ -45,38 +45,35 @@ EOF
 -----BEGIN CERTIFICATE-----
 42JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
         expected_result => [
-            <<'EOF',
+            q{
 -----BEGIN CERTIFICATE-----
 12JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
-            <<'EOF',
------BEGIN CERTIFICATE-----
+            q{-----BEGIN CERTIFICATE-----
 22JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
-            <<'EOF',
------BEGIN CERTIFICATE-----
+            q{-----BEGIN CERTIFICATE-----
 32JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
-            <<'EOF',
------BEGIN CERTIFICATE-----
+            q{-----BEGIN CERTIFICATE-----
 42JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
         ],
     },
     {
         expected_success => 1,
         name => "leading and interleaved text pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
@@ -101,10 +98,10 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
         expected_result => [
-            <<'EOF',
+            q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
@@ -113,10 +110,9 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
-            <<'EOF',
-Subject: CN=Org Issuing CA 3
+            q{Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
 2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
@@ -124,10 +120,9 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
-            <<'EOF',
-Subject: CN=Org Root CA
+            q{Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
 3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
@@ -135,13 +130,13 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
         ],
     },
     {
         expected_success => 1,
         name => "massive glob pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
@@ -164,12 +159,12 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
     },
     {
         expected_success => 1,
         name => "no beginning pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
@@ -184,10 +179,10 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
 
         expected_result => [
-            <<'EOF',
+            q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
@@ -195,24 +190,22 @@ dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
-
-            <<'EOF',
-Subject: CN=Org Root CA
+},
+            q{Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
 3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
 dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
 dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
         ],
 
     },
     {
         expected_success => 0,
         name => "not a pem pem",
-        pem => <<'EOF',
+        pem => q{
 Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
@@ -221,12 +214,12 @@ dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
-EOF
+},
     },
     {
         expected_success => 1,
         name => "following text pem",
-        pem => <<'EOF',
+        pem => q{
 -----BEGIN CERTIFICATE-----
 32JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
@@ -234,20 +227,18 @@ EOF
 42JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
 some more text that we would like to remove
-EOF
+},
 
         expected_result => [
-            <<'EOF',
+            q{
 -----BEGIN CERTIFICATE-----
 32JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
-
-            <<'EOF',
------BEGIN CERTIFICATE-----
+},
+            q{-----BEGIN CERTIFICATE-----
 42JlZ2tseTxzZWl2IGF3ZWlidm4=
 -----END CERTIFICATE-----
-EOF
+},
         ],
     },
 ];
-- 
2.47.3





  reply	other threads:[~2026-11-18 10:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 10:31 [PATCH common v2 00/11] pem parser: refactor parsing to cover more edge cases Thomas Ellmenreich
2026-11-18 10:31 ` Thomas Ellmenreich [this message]
2026-11-18 10:31 ` [PATCH common v2 02/11] pem parser: add constant to match any label Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 03/11] pem parser: refactor check_pem to use list instead of string Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 04/11] pem parser: stricter handling of newlines Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 05/11] certificate formats: enable multiple parsing for pem-string format Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 06/11] pem parsing: strip all surrounding text from chain entries Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 07/11] pem parsing: make validation of pem entry stricter Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 08/11] pem parsing: default splitting to any label Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 09/11] pem to der: create clearer error boundary Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 10/11] certificate tests: refactor and exapand testsuite Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 11/11] pom parsing: allow for CRLF line ending Thomas Ellmenreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118103127.165100-2-t.ellmenreich@proxmox.com \
    --to=t.ellmenreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal