public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
Subject: [PATCH common v2 10/11] certificate tests: refactor and exapand testsuite
Date: Wed, 18 Nov 2026 11:31:24 +0100	[thread overview]
Message-ID: <20261118103127.165100-11-t.ellmenreich@proxmox.com> (raw)
In-Reply-To: <20261118103127.165100-1-t.ellmenreich@proxmox.com>

The previous tests were testing the functionality of internal methods
through 'check_pem' which lead to a lot of convoluted tests. The new
certificate_utils_test now contains tests for these internal utilities
so that tests for functions like check_pem can focus on its specific
functionality.

With the refactor of the tests also replaced most of the base64 content
with a base64 encoded 'Lorem Ipsum'.

Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
---
 src/PVE/Certificate.pm         |  12 +-
 test/Makefile                  |   1 +
 test/certificate_utils_test.pl | 347 ++++++++++++++++++++++++++++++
 test/check_pem_test.pl         | 381 +++++++++++++--------------------
 test/split_pem_test.pl         | 151 +++++--------
 5 files changed, 556 insertions(+), 336 deletions(-)
 create mode 100755 test/certificate_utils_test.pl

diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm
index 2f65568..c89c9e2 100644
--- a/src/PVE/Certificate.pm
+++ b/src/PVE/Certificate.pm
@@ -117,7 +117,7 @@ my $footer_re = sub {
     return qr!(?m:^)-----END\ $label-----(?:\z|\n(?=\s*\S))!;
 };
 
-my $pem_re = sub {
+sub __pem_re {
     my ($label) = @_;
 
     my $b64_char_re = qr![0-9A-Za-z\+/]\n*!; # see RFC 7468
@@ -132,7 +132,7 @@ my $pem_re = sub {
             |(?:$b64_char_re){2}=\s*=\s*)
         $footer
     }x;
-};
+}
 
 my sub trim_trailing_space {
     my ($content) = @_;
@@ -141,7 +141,7 @@ my sub trim_trailing_space {
     return $content;
 }
 
-my sub strip_surrounding_text {
+sub __strip_surrounding_text {
     my ($content, %opts) = @_;
 
     my $label = $opts{label} // $ANY_LABEL;
@@ -177,7 +177,7 @@ sub check_pem {
     my ($content, %opts) = @_;
 
     my $label = $opts{label} // ($opts{any_label} ? $ANY_LABEL : 'CERTIFICATE');
-    my $re = $pem_re->($label);
+    my $re = __pem_re($label);
 
     my @split =
         $opts{multiple}
@@ -191,7 +191,7 @@ sub check_pem {
 
     my @result_entries = ();
     for my $entry (@split) {
-        my $stripped = strip_surrounding_text($entry, label => $label);
+        my $stripped = __strip_surrounding_text($entry, label => $label);
 
         if ($stripped !~ /$re/) {
             @result_entries = ();
@@ -214,7 +214,7 @@ sub pem_to_der {
     my $header = $header_re->($ANY_LABEL);
     my $footer = $footer_re->($ANY_LABEL);
 
-    $content = strip_surrounding_text($content);
+    $content = __strip_surrounding_text($content);
 
     # only take first PEM entry
     $content =~ s/$header//mg
diff --git a/test/Makefile b/test/Makefile
index f111511..b65671e 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -20,6 +20,7 @@ TESTS = lock_file.test			\
 	check_pem_test.test \
 	split_pem_test.test \
 	pem_to_der_test.test \
+	certificate_utils_test.test \
 
 all:
 
diff --git a/test/certificate_utils_test.pl b/test/certificate_utils_test.pl
new file mode 100755
index 0000000..873a549
--- /dev/null
+++ b/test/certificate_utils_test.pl
@@ -0,0 +1,347 @@
+#!/usr/bin/perl
+# Tests for a few of the smaller PVE::Certificate utilities to check the
+# correctness and coverage of edgecases.
+use strict;
+use warnings;
+
+use lib '../src';
+
+use Test::More;
+
+use PVE::Certificate;
+
+############################################
+####    strip_leading_text/_and_trim    ####
+############################################
+
+my $setup_strip_leading_text = [
+    {
+        name => "simple leading text",
+        pem => q{Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "leading text with leading newline",
+        pem => q{
+Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----}
+    },
+    {
+        name => "leading text with trailing newline",
+        pem => q{Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "trailing newlines and whitespaces are trimmed",
+        pem => q{Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+ 
+  
+
+  
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "no leading text",
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "leading and trailing newlines",
+        pem => q{
+
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "multiple entries with interleaved text",
+        pem => q{Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0gMQ==
+-----END CERTIFICATE-----
+Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0gMg==
+-----END CERTIFICATE-----},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0gMQ==
+-----END CERTIFICATE-----}
+    },
+];
+
+for my $data ($setup_strip_leading_text->@*) {
+    subtest $data->{name} => sub {
+        # Act
+        my $result = PVE::Certificate::__strip_surrounding_text($data->{pem});
+
+        # Assert
+        is(
+            $result, $data->{expected_result}, "has correct result",
+        );
+    }
+}
+
+############################################
+####               pem_re               ####
+############################################
+
+my $setup_pem_re = [
+    {
+        name => "simple pem",
+        expected_match => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "with leading text",
+        expected_match => 0,
+        pem => q{Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "leading newline",
+        expected_match => 0,
+        pem => q{
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "trailing newline",
+        expected_match => 0,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+},
+    },
+    {
+        name => "non base64 chars",
+        expected_match => 0,
+        pem => q{-----BEGIN CERTIFICATE-----
+some #!"§/(%T) non base 64 chars=
+-----END CERTIFICATE-----
+},
+    },
+    {
+        name => "missing trailing equals",
+        expected_match => 0,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "multiline missing trailing equals",
+        expected_match => 0,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0
+TG9yZW0gaXBzdW0
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "glob label",
+        expected_match => 1,
+        label => qr/.*?/,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "incorrect label",
+        expected_match => 0,
+        label => "OTHER",
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "two terminating equals",
+        expected_match => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW==
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "second equals on newline",
+        expected_match => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW=
+=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content after terminating equals",
+        expected_match => 0,
+        label => "OTHER",
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+=
+some extra content
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content spaced out",
+        expected_match => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+
+TG9yZW0gaXBzdW0=
+
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "no content between begin and end",
+        expected_match => 0,
+        pem => q{-----BEGIN CERTIFICATE-----
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "only newlines content",
+        expected_match => 0,
+        pem => q{-----BEGIN CERTIFICATE-----
+
+
+
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content after end",
+        expected_match => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+some extended content},
+    },
+    {
+        name => "only newlines content",
+        expected_match => 0,
+        pem => q{
+
+},
+    },
+    {
+        name => "upsidedown begin and end",
+        expected_match => 0,
+        pem => q{
+-----END CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----BEGIN CERTIFICATE-----},
+    },
+    {
+        name => "multi pem",
+        expected_match => 1,
+        multiple => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0gMQ==
+-----END CERTIFICATE-----
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0gMg==
+-----END CERTIFICATE-----
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0gMw==
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content length divisible by 4",
+        expected_match => 1,
+        multiple => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0x
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content length missing 1",
+        expected_match => 1,
+        multiple => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content length missing 2",
+        expected_match => 1,
+        multiple => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW==
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content has to be divisible by 4 negative case",
+        expected_match => 0,
+        multiple => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+asdfkljnasdkfbakjhsdbfe
+TG9yZW0gaXBzdW==
+-----END CERTIFICATE-----},
+    },
+    {
+        name => "content has to be divisible by 4 positive case",
+        expected_match => 1,
+        multiple => 1,
+        pem => q{-----BEGIN CERTIFICATE-----
+asdfkljnasdkfbakjhsdbfe2
+TG9yZW0gaXBzdW==
+-----END CERTIFICATE-----},
+    },
+];
+
+for my $data ($setup_pem_re->@*) {
+    subtest $data->{name} => sub {
+        # Act
+        my $pem_re = PVE::Certificate::__pem_re($data->{label} // 'CERTIFICATE');
+        my $matches = ($data->{pem} =~ $pem_re);
+
+        my $error_data = "\n'" . $data->{pem} . "'\n\nby pem_re:\n\n'" . $pem_re . "'";
+
+        if ($data->{expected_match}) {
+            ok($matches, "was correctly accepted")
+                or diag "this was wrongfully DENIED:" . $error_data;
+        } else {
+            ok(!$matches, "was correctly rejected")
+                or diag "this was wrongfully ACCEPTED:" . $error_data;
+        }
+
+    }
+}
+
+done_testing();
+
diff --git a/test/check_pem_test.pl b/test/check_pem_test.pl
index c074505..73e9826 100755
--- a/test/check_pem_test.pl
+++ b/test/check_pem_test.pl
@@ -14,7 +14,7 @@ use PVE::Certificate;
 my $setup = [
     {
         expected_success => 1,
-        name => "full pem",
+        name => "single pem",
         pem => q{-----BEGIN CERTIFICATE-----
 MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
 AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
@@ -23,307 +23,220 @@ EwJVUzELMAkGA1UECAwCQ0ExEDAOBgNVBAcMB0JlcmtlbGV5MRAwDgYDVQQKDAdU
 ZXN0IENBMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEv5Q8q1p7qZ2gqkQ0Qn5x
 0n9yqv8n8n7n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8aNT
 MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
-Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
-TG9yZW0gaXBzdW0=
+Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwE=
 -----END CERTIFICATE-----},
     },
     {
         expected_success => 1,
-        name => "other label pem",
-        label => "SOME LABEL",
-        pem => q{-----BEGIN SOME LABEL-----
-MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
-AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
-c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
-EwJVUzELMAkGA1UECAwCQ0ExEDAOBgNVBAcMB0JlcmtlbGV5MRAwDgYDVQQKDAdU
-ZXN0IENBMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEv5Q8q1p7qZ2gqkQ0Qn5x
-0n9yqv8n8n7n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8n8aNT
-MFEwHQYDVR0OBBYEFOu2Y0bq8v3z7qkq1m1Qwqkq1m1QMB8GA1UdIwQYMBaAFOu2
-Y0bq8v3z7qkq1m1Qwqkq1m1QMA8GA1UdEwEB/wQFMAMBAf8wCgYIKoZIzj0EAwID
-TG9yZW0gaXBzdW0=
------END SOME LABEL-----},
-    },
-    {
-        expected_success => 1,
-        name => "simple pem",
+        name => "single pem as multiple",
+        multiple => 1,
         pem => q{-----BEGIN CERTIFICATE-----
 TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
     },
     {
         expected_success => 1,
-        name => "spaced out pem",
-        pem => q{-----BEGIN CERTIFICATE-----
-
-TG9yZW0gaXBzdW0=
-
------END CERTIFICATE-----},
-    },
-    {
-        expected_success => 0,
-        name => "only newline pem",
-        pem => q{-----BEGIN CERTIFICATE-----
------END CERTIFICATE-----},
-    },
-    {
-        expected_success => 0,
-        name => "many newlines pem",
-        pem => q{-----BEGIN CERTIFICATE-----
-
-
-
------END CERTIFICATE-----},
-    },
-    {
-        expected_success => 0,
-        name => "no content pem",
+        name => "simple pem with surrounding newlines",
         pem => q{
------BEGIN CERTIFICATE----------END CERTIFICATE-----},
-    },
-    {
-        expected_success => 1,
-        name => "preceding content pem",
-        pem => q{
-some extended content
------BEGIN CERTIFICATE-----
-TG9yZW0gaXBzdW0=
------END CERTIFICATE-----},
 
-        expected_result => q{-----BEGIN CERTIFICATE-----
-TG9yZW0gaXBzdW0=
------END CERTIFICATE-----},
-    },
-    {
-        expected_success => 1,
-        name => "following content pem",
-        pem => q{
 -----BEGIN CERTIFICATE-----
 TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
-some extended content},
-        expected_result => q{-----BEGIN CERTIFICATE-----
-TG9yZW0gaXBzdW0=
------END CERTIFICATE-----}
-    },
-    {
-        expected_success => 0,
-        name => "empty pem",
-        pem => q{
 
 },
-    },
-    {
-        expected_success => 0,
-        name => "upsidedown pem",
-        pem => q{
------END CERTIFICATE-----
+        expected_result => q{-----BEGIN CERTIFICATE-----
 TG9yZW0gaXBzdW0=
------BEGIN CERTIFICATE-----},
+-----END CERTIFICATE-----}
     },
     {
         expected_success => 1,
-        name => "multi pem",
+        name => "multiple pem with interleaved text",
         multiple => 1,
-        pem => q{-----BEGIN CERTIFICATE-----
-12JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----
+        pem => q{Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
-22JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-32JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-42JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----}
     },
     {
         expected_success => 1,
-        name => "multiple as single pem",
-        pem => q{
-Subject: CN=some.test.content
+        name => "chain with different labels but allow all",
+        multiple => 1,
+        any_label => 1,
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
------BEGIN CERTIFICATE-----
-TG9yZW0gaXBzdW0gMQ==
------END CERTIFICATE-----
+-----BEGIN A-----
+TG9yZW0gaXBzdW0=
+-----END A-----
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
------BEGIN CERTIFICATE-----
-TG9yZW0gaXBzdW0gMg==
------END CERTIFICATE-----},
-        expected_result => q{-----BEGIN CERTIFICATE-----
-TG9yZW0gaXBzdW0gMQ==
------END CERTIFICATE-----}
+-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN C-----
+TG9yZW0gaXBzdW0=
+-----END C-----},
+        expected_result => q{-----BEGIN A-----
+TG9yZW0gaXBzdW0=
+-----END A-----
+-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----
+-----BEGIN C-----
+TG9yZW0gaXBzdW0=
+-----END C-----}
     },
     {
         expected_success => 1,
-        name => "multiple pem",
+        name => "chain with different labels but only allow B",
         multiple => 1,
-        pem => q{
-Subject: CN=some.test.content
+        label => "B",
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
------BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----
+-----BEGIN A-----
+TG9yZW0gaXBzdW0=
+-----END A-----
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
------BEGIN CERTIFICATE-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
-        expected_result => q{-----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----
------BEGIN CERTIFICATE-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
+-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN C-----
+TG9yZW0gaXBzdW0=
+-----END C-----},
+        expected_result => q{-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----}
     },
     {
         expected_success => 1,
-        name => "big pem different label",
+        name => "chain with different labels but only allow interleaved B",
         multiple => 1,
-        label => "LABEL",
-        pem => q{
-Subject: CN=some.test.content
+        label => "B",
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
------BEGIN LABEL-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END LABEL-----
+-----BEGIN A-----
+TG9yZW0gaXBzdW0=
+-----END A-----
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
------BEGIN LABEL-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END LABEL-----
-Subject: CN=Org Root CA
+-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----
+Subject: CN=some.test.content
+Issuer: CN=Org Issuing CA 3
+-----BEGIN A-----
+TG9yZW0gaXBzdW0=
+-----END A-----
+Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
------BEGIN LABEL-----
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END LABEL-----},
-
-        expected_result => q{-----BEGIN LABEL-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END LABEL-----
------BEGIN LABEL-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END LABEL-----
------BEGIN LABEL-----
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END LABEL-----},
+-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----},
+        expected_result => q{-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----
+-----BEGIN B-----
+TG9yZW0gaXBzdW0=
+-----END B-----}
     },
     {
         expected_success => 1,
-        name => "other real pem",
-        pem => q{
-Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
-Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
+        name => "chain was single",
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
-        expected_result => q{-----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
-    },
-    {
-        expected_success => 0,
-        name => "invalid single pem",
-        pem => q{
-Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
-Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdthese !?''*:;$%&/  are not allowedWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----}
     },
     {
-        expected_success => 0,
-        name => "invalid multi pem",
-        multiple => 1,
-        pem => q{
-Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
-Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
+        expected_success => 1,
+        name => "chain was single",
+        pem => q{Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdthese !?''*:;$%&/  are not allowedWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
-Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
-Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----
+},
+        expected_result => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
+-----END CERTIFICATE-----}
     },
     {
         expected_success => 1,
-        name => "single as multiple pem",
+        name => "pem with ec parameters",
         multiple => 1,
-        pem => q{-----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
+        any_label => 1,
+        pem => q{
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN EC PARAMETERS-----
+TG9yZW0gaXBzdW0=
+-----END EC PARAMETERS-----
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN EC PRIVATE KEY-----
+TG9yZW0gaXBzdW0=
+-----END EC PRIVATE KEY-----},
+        expected_result => q{-----BEGIN EC PARAMETERS-----
+TG9yZW0gaXBzdW0=
+-----END EC PARAMETERS-----
+-----BEGIN EC PRIVATE KEY-----
+TG9yZW0gaXBzdW0=
+-----END EC PRIVATE KEY-----}
     },
     {
         expected_success => 1,
-        name => "single as multiple pem",
+        name => "pem with ec parameters",
         multiple => 1,
+        label => "EC PRIVATE KEY",
         pem => q{
-Subject: CN=Some subject with 2 Points,O=A Organization,L=Some Lation,C=TT
-Issuer: CN=The Orgs Name RootCA 2015,O=The Orgs name Institutions Cert. Authority,L=Location,C=TT
------BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
-        expected_result => q{-----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdtheseZ2RmaXVwYWJ2aXV1YXdlYmxmamlraWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
------END CERTIFICATE-----},
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN EC PARAMETERS-----
+TG9yZW0gaXBzdW0=
+-----END EC PARAMETERS-----
+Subject: CN=Org Issuing CA 3
+Issuer: CN=Org Root CA
+-----BEGIN EC PRIVATE KEY-----
+TG9yZW0gaXBzdW0=
+-----END EC PRIVATE KEY-----},
+        expected_result => q{-----BEGIN EC PRIVATE KEY-----
+TG9yZW0gaXBzdW0=
+-----END EC PRIVATE KEY-----}
     },
 ];
 
@@ -335,6 +248,7 @@ for my $data ($setup->@*) {
             noerr => 1,
             multiple => $data->{multiple},
             label => $data->{label},
+            any_label => $data->{any_label},
         );
 
         # Assert
@@ -355,6 +269,7 @@ for my $data ($setup->@*) {
                     $data->{pem},
                     multiple => $data->{multiple},
                     label => $data->{label},
+                    any_label => $data->{any_label},
                 );
             };
             ok($@, "has correctly thrown an error");
diff --git a/test/split_pem_test.pl b/test/split_pem_test.pl
index fdc961e..02cce94 100755
--- a/test/split_pem_test.pl
+++ b/test/split_pem_test.pl
@@ -15,8 +15,7 @@ my $setup = [
     {
         expected_success => 1,
         name => "single pem",
-        pem => q{
------BEGIN CERTIFICATE-----
+        pem => q{-----BEGIN CERTIFICATE-----
 MIIBsjCCAVugAwIBAgIJAO2g8Z0dXk9tMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT
 AlVTMQswCQYDVQQIDAJDQTEQMA4GA1UEBwwHQmVya2VsZXkxEDAOBgNVBAoMB1Rl
 c3QgQ0EwHhcNMjAwMTAxMDAwMDAwWhcNMzAwMTAxMDAwMDAwWjBFMQswCQYDVQQG
@@ -31,39 +30,33 @@ SAAwRQIhANfakefakefakefakefakefakefakefakefake
     {
         expected_success => 1,
         name => "no extra text pem",
-        pem => q{
------BEGIN CERTIFICATE-----
-12JlZ2tseTxzZWl2IGF3ZWlidm4=
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-22JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-32JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-42JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
-
         expected_result => [
-            q{
------BEGIN CERTIFICATE-----
-12JlZ2tseTxzZWl2IGF3ZWlidm4=
+            q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
-
             q{-----BEGIN CERTIFICATE-----
-22JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
-
             q{-----BEGIN CERTIFICATE-----
-32JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
-
             q{-----BEGIN CERTIFICATE-----
-42JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
         ],
     },
@@ -121,139 +114,86 @@ some test text
     {
         expected_success => 1,
         name => "leading and interleaved text pem",
-        pem => q{
-Subject: CN=some.test.content
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
-
         expected_result => [
-            q{
-Subject: CN=some.test.content
+            q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
-
             q{Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
-
             q{Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
         ],
     },
     {
         expected_success => 1,
         name => "massive glob pem",
-        pem => q{
-Subject: CN=some.test.content
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
 -----BEGIN CERTIFICATE-----
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
 -----BEGIN CERTIFICATE-----
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
     },
     {
         expected_success => 1,
         name => "no beginning pem",
-        pem => q{
-Subject: CN=some.test.content
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
-
         expected_result => [
-            q{
-Subject: CN=some.test.content
+            q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
-2WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
             q{Subject: CN=Org Root CA
 Issuer: CN=Org Root CA
-3WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
-c2JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----},
         ],
-
     },
     {
         expected_success => 0,
         name => "not a pem pem",
-        pem => q{
-Subject: CN=some.test.content
+        pem => q{Subject: CN=some.test.content
 Issuer: CN=Org Issuing CA 3
-1WtzZGhmbGtqYXNoZ2RmaXVwYWJ2aXV1YXdlYmxmamlraGFzZGtmYWlzdXBkdW5i
-dmFpdXdlYmdmw7ZrYWpkc2JoZmdpYXNkbmJpZnVhYmdzaWprZmdyYXNkaHJmaW9h
-dXNkbmF1c2JmZ3ZramFzZGJma2phc2RibmZpanVhIHNkb3ZuYmF3b3VlYmZnb2F3
 c2JlZ2tseTxzZWl2IGF3ZWlidm4=
 Subject: CN=Org Issuing CA 3
 Issuer: CN=Org Root CA},
@@ -261,27 +201,44 @@ Issuer: CN=Org Root CA},
     {
         expected_success => 1,
         name => "following text pem",
-        pem => q{
------BEGIN CERTIFICATE-----
-32JlZ2tseTxzZWl2IGF3ZWlidm4=
+        pem => q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 -----BEGIN CERTIFICATE-----
-42JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 some more text that we would like to remove},
-
         expected_result => [
-            q{
------BEGIN CERTIFICATE-----
-32JlZ2tseTxzZWl2IGF3ZWlidm4=
+            q{-----BEGIN CERTIFICATE-----
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
             q{-----BEGIN CERTIFICATE-----
-42JlZ2tseTxzZWl2IGF3ZWlidm4=
+TG9yZW0gaXBzdW0=
 -----END CERTIFICATE-----
 },
         ],
     },
+    {
+        expected_success => 1,
+        name => "different labels pem",
+        pem => q{-----BEGIN LABEL A-----
+TG9yZW0gaXBzdW0=
+-----END LABEL A-----
+-----BEGIN LABEL B-----
+TG9yZW0gaXBzdW0=
+-----END LABEL B-----},
+
+        expected_result => [
+            q{-----BEGIN LABEL A-----
+TG9yZW0gaXBzdW0=
+-----END LABEL A-----
+},
+            q{-----BEGIN LABEL B-----
+TG9yZW0gaXBzdW0=
+-----END LABEL B-----},
+        ],
+    },
 ];
 
 for my $data ($setup->@*) {
-- 
2.47.3





  parent reply	other threads:[~2026-11-18 10:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 10:31 [PATCH common v2 00/11] pem parser: refactor parsing to cover more edge cases Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 01/11] certificate tests: use q{} for multiline strings Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 02/11] pem parser: add constant to match any label Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 03/11] pem parser: refactor check_pem to use list instead of string Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 04/11] pem parser: stricter handling of newlines Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 05/11] certificate formats: enable multiple parsing for pem-string format Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 06/11] pem parsing: strip all surrounding text from chain entries Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 07/11] pem parsing: make validation of pem entry stricter Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 08/11] pem parsing: default splitting to any label Thomas Ellmenreich
2026-11-18 10:31 ` [PATCH common v2 09/11] pem to der: create clearer error boundary Thomas Ellmenreich
2026-11-18 10:31 ` Thomas Ellmenreich [this message]
2026-11-18 10:31 ` [PATCH common v2 11/11] pom parsing: allow for CRLF line ending Thomas Ellmenreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118103127.165100-11-t.ellmenreich@proxmox.com \
    --to=t.ellmenreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal