public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH dab] allow building s390x appliance templates
@ 2026-11-18  8:57 Yvan Janssens
  0 siblings, 0 replies; only message in thread
From: Yvan Janssens @ 2026-11-18  8:57 UTC (permalink / raw)
  To: pve-devel

Same reasoning as for arm64: dab is its own bootstrapper and already
fetches binary-<arch> indices and unpacks the debs architecture
agnostically, so an s390x target only needs the validation gate opened.

For usr-merge, s390x needs lib32 in addition to the base set, matching
debootstrap's link_dir for s390x.

As with arm64, dab does not emulate foreign architectures, so s390x
templates have to be built on an s390x host.

Signed-off-by: Yvan Janssens <yvanj@cyber.gent>
---
 PVE/DAB.pm | 4 +++-
 dab        | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/PVE/DAB.pm b/PVE/DAB.pm
index 77a3bee..77a9e61 100644
--- a/PVE/DAB.pm
+++ b/PVE/DAB.pm
@@ -770,6 +770,8 @@ sub setup_usr_merge {
         push @merged_dirs, qw(lib32 lib64 libx32);
     } elsif ($arch eq 'i386') {
         push @merged_dirs, qw(lib64 libx32);
+    } elsif ($arch eq 's390x') {
+        push @merged_dirs, qw(lib32);
     }
     # arm64 needs no extra lib directories beyond the base set, matching debootstrap's link_dir
 
@@ -814,7 +816,7 @@ sub new {
     $self->{logfd}->autoflush(1);
 
     my $arch = $config->{architecture} || die "no 'architecture' specified\n";
-    die "unsupported architecture '$arch'\n" if $arch !~ m/^(i386|amd64|arm64)$/;
+    die "unsupported architecture '$arch'\n" if $arch !~ m/^(i386|amd64|arm64|s390x)$/;
 
     my $suite = $config->{suite} || die "no 'suite' specified\n";
 
diff --git a/dab b/dab
index 4930fe9..7bb2dcd 100755
--- a/dab
+++ b/dab
@@ -552,7 +552,7 @@ Appliance names must consist only of lower case letters (a-z), digits (0-9),
 plus (+) and minus (-) signs, and periods (.). They must be at least two
 characters long and must start with an alphanumeric character.
 
-=item B<Architecture:> I<i386|amd64|arm64>
+=item B<Architecture:> I<i386|amd64|arm64|s390x>
 
 Target architecture. Note that dab does not emulate foreign architectures, so
 the build host's architecture has to match the target (for example, build
-- 
2.54.0 (Apple Git-157)





^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-18  9:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  8:57 [PATCH dab] allow building s390x appliance templates Yvan Janssens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal