public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox 40/55] notify: context: add read_config
Date: Fri, 13 Nov 2026 16:08:13 +0100	[thread overview]
Message-ID: <20261113150828.756836-41-l.wagner@proxmox.com> (raw)
In-Reply-To: <20261113150828.756836-1-l.wagner@proxmox.com>

The worker needs the ability to read the notification configuration,
which is implemented by adding a 'read_config' method to the ContextImpl
trait.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 proxmox-notify/src/context/mod.rs  |  4 ++++
 proxmox-notify/src/context/pbs.rs  | 19 +++++++++++++++++++
 proxmox-notify/src/context/pve.rs  | 17 +++++++++++++++++
 proxmox-notify/src/context/test.rs | 21 ++++++++++++++++++---
 4 files changed, 58 insertions(+), 3 deletions(-)

diff --git a/proxmox-notify/src/context/mod.rs b/proxmox-notify/src/context/mod.rs
index c31e108fd..eb8011cf3 100644
--- a/proxmox-notify/src/context/mod.rs
+++ b/proxmox-notify/src/context/mod.rs
@@ -5,6 +5,7 @@ use std::sync::Arc;
 use proxmox_http::ProxyConfig;
 use proxmox_section_config::typed::SectionConfigData;
 
+use crate::Config;
 use crate::config::ConfigEntity;
 use crate::error::BoxedError;
 
@@ -63,6 +64,9 @@ pub trait ContextImpl: Send + Sync + Debug {
         namespace: Option<&str>,
         source: TemplateSource,
     ) -> Result<Option<String>, BoxedError>;
+
+    /// Read notification config.
+    fn read_config(&self) -> Result<Config, BoxedError>;
 }
 
 /// Choose between the provided `vendor` template or its by the user optionally created `override`
diff --git a/proxmox-notify/src/context/pbs.rs b/proxmox-notify/src/context/pbs.rs
index 7d3c51677..046d37055 100644
--- a/proxmox-notify/src/context/pbs.rs
+++ b/proxmox-notify/src/context/pbs.rs
@@ -9,6 +9,7 @@ use proxmox_schema::{ObjectSchema, Schema, StringSchema};
 use proxmox_section_config::typed::{ApiSectionDataEntry, SectionConfigData};
 use proxmox_section_config::{SectionConfig, SectionConfigPlugin};
 
+use crate::Config;
 use crate::config::ConfigEntity;
 use crate::context::{ContextImpl, TemplateSource, common};
 use crate::error::BoxedError;
@@ -136,6 +137,24 @@ impl ContextImpl for PBSContext {
 
         Ok(template_string)
     }
+
+    fn read_config(&self) -> Result<Config, BoxedError> {
+        let raw_config =
+            proxmox_sys::fs::file_read_optional_string("/etc/proxmox-backup/notifications.cfg")?
+                .unwrap_or_default();
+        let raw_private_config = proxmox_sys::fs::file_read_optional_string(
+            "/etc/proxmox-backup/notifications-priv.cfg",
+        )?
+        .unwrap_or_default();
+
+        let config = Config::parse_section_config(
+            &raw_config,
+            &raw_private_config,
+            Some(self.default_config()),
+        )?;
+
+        Ok(config)
+    }
 }
 
 #[cfg(test)]
diff --git a/proxmox-notify/src/context/pve.rs b/proxmox-notify/src/context/pve.rs
index a020b5cb4..f7d2ac13c 100644
--- a/proxmox-notify/src/context/pve.rs
+++ b/proxmox-notify/src/context/pve.rs
@@ -4,6 +4,7 @@ use std::sync::OnceLock;
 use proxmox_http::ProxyConfig;
 use proxmox_section_config::typed::{ApiSectionDataEntry, SectionConfigData};
 
+use crate::Config;
 use crate::config::ConfigEntity;
 use crate::context::{ContextImpl, TemplateSource, common};
 use crate::error::BoxedError;
@@ -87,6 +88,22 @@ impl ContextImpl for PVEContext {
 
         Ok(template_string)
     }
+
+    fn read_config(&self) -> Result<Config, BoxedError> {
+        let raw_config = proxmox_sys::fs::file_read_optional_string("/etc/pve/notifications.cfg")?
+            .unwrap_or_default();
+        let raw_private_config =
+            proxmox_sys::fs::file_read_optional_string("/etc/pve/priv/notifications.cfg")?
+                .unwrap_or_default();
+
+        let config = Config::parse_section_config(
+            &raw_config,
+            &raw_private_config,
+            Some(self.default_config()),
+        )?;
+
+        Ok(config)
+    }
 }
 
 pub static PVE_CONTEXT: PVEContext = PVEContext;
diff --git a/proxmox-notify/src/context/test.rs b/proxmox-notify/src/context/test.rs
index 6061e8c4d..bc68b6e41 100644
--- a/proxmox-notify/src/context/test.rs
+++ b/proxmox-notify/src/context/test.rs
@@ -3,6 +3,7 @@ use std::sync::OnceLock;
 use proxmox_http::ProxyConfig;
 use proxmox_section_config::typed::SectionConfigData;
 
+use crate::Config;
 use crate::Context;
 use crate::config::ConfigEntity;
 use crate::context::ContextImpl;
@@ -10,8 +11,11 @@ use crate::error::BoxedError;
 
 use super::TemplateSource;
 
-#[derive(Debug)]
-pub(crate) struct TestContext;
+#[derive(Debug, Default)]
+pub(crate) struct TestContext {
+    /// Make [`ContextImpl::read_config`] fail, to test how callers handle an unreadable config.
+    pub(crate) fail_read_config: bool,
+}
 
 impl ContextImpl for TestContext {
     fn lookup_email_for_user(&self, user: &str) -> Option<String> {
@@ -49,8 +53,19 @@ impl ContextImpl for TestContext {
     ) -> Result<Option<String>, BoxedError> {
         Ok(Some(String::new()))
     }
+
+    fn read_config(&self) -> Result<Config, BoxedError> {
+        if self.fail_read_config {
+            return Err(Box::new(crate::Error::other(
+                "injected config read failure",
+            )));
+        }
+
+        // An empty config has no targets and no matchers.
+        Ok(Config::parse_section_config("", "", None)?)
+    }
 }
 
 pub(crate) fn test_context() -> Context {
-    Context::new(TestContext)
+    Context::new(TestContext::default())
 }
-- 
2.47.3





  parent reply	other threads:[~2026-11-13 15:15 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:07 [PATCH many 00/55] notify: maintenance, PDM preparations, queue + worker Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 01/55] notify: disallow `unsafe` code Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 02/55] notify: refactor error type Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 03/55] notify: move `Endpoint` trait to endpoint module as pub(crate) Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 04/55] notify: use ConfigDigest instead of raw byte arrays Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 05/55] notify: remove static context and pass context as parameter Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 06/55] notify: matcher: drop unused field matcher verifiers Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 07/55] notify: introduce 'send-impl', 'api-impl' and 'api-types' features Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 08/55] notify: matcher: make matcher validation methods public Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 09/55] notify: make SendmailEndpoint and SmtpEndpoint private types Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 10/55] notify: move `send`, `test_target` and `Bus` to new `send` module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 11/55] notify: move Origin type to api_types module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 12/55] notify: move Target " Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 13/55] notify: move Config to config module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 14/55] notify: move Notification and sub-types to `notification` module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 15/55] notify: move schema module to api_types Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 16/55] notify: move check_matches from api_types::matcher to send::Bus Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 17/55] notify: move TemplateSource to context module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 18/55] notify: config: cleanup helpers names and visibility Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 19/55] notify: config: rename section config parser/writer methods Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 20/55] notify: config: pass builtins explicitly when parsing section config Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 21/55] notify: implement PartialEq for all Config types Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 22/55] notify: use typed SectionConfigData Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 23/55] notify: api: api types: rename Deleteable* -> Deletable* Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 24/55] notify: context: parse builtin config only once Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 25/55] notify: context: parse proxy config in trait impl, not at the callsite Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 26/55] notify: gate sub-modules with the appropriate feature flags Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 27/55] notify: fold mail-forwarder feature into send-impl Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 28/55] notify: forwarded mails: don't hardcode severity and metadata fields Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 29/55] notify: don't pass uid when instantiating forwarded mail notifications Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 30/55] notify: derive PartialEq for Notification type Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 31/55] notify: add getters for severity and fields on " Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 32/55] notify: add test suite for " Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 33/55] notify: serialize raw, forwarded mail content as base64 Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 34/55] notify: unify code paths for legacy-sendmail and regular notifications Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 35/55] notify: add backwards-compat note to Notification type Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 36/55] notify: remove 'test_target' API Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 37/55] notify: replace notification instantiation with builder pattern Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 38/55] notify: add send receipts Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 39/55] notify: implement notification queue submitter Lukas Wagner
2026-11-13 15:08 ` Lukas Wagner [this message]
2026-11-13 15:08 ` [PATCH proxmox 41/55] notify: queue: add queue consumer Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 42/55] notify: queue: add worker task Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 43/55] notifications: don't ignore verification errors in legacy-sendmail mode Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 44/55] notifications: adapt to proxmox-notify API changes Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 45/55] api: notification: send test notification via proxmox_notify::send Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 46/55] notifications: send all notifications via proxmox-notify's queue Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-perl-rs 47/55] pve: notify: adapt to changes in the public API of proxmox-notify Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-perl-rs 48/55] pve: notify: add `PVE::RS::Notify::enqueue` method Lukas Wagner
2026-11-13 15:08 ` [PATCH pve-cluster 49/55] notify: send notifications via notification queue Lukas Wagner
2026-11-13 15:08 ` [PATCH manager 50/55] vzdump: send legacy-sendmail notifications via simplified API Lukas Wagner
2026-11-13 15:08 ` [PATCH manager 51/55] pve-notify-worker: add new rust-based notification worker daemon Lukas Wagner
2026-11-13 15:08 ` [PATCH manager 52/55] debian: add 'pve-notify-worker' as a dependency Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-mail-forward 53/55] forward mails via notification queue Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-mail-forward 54/55] use return code to signal permanent or temporary failure Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-mail-forward 55/55] limit size of mail read from stdin Lukas Wagner
2026-11-17  9:35 ` [PATCH many 00/55] notify: maintenance, PDM preparations, queue + worker Lukas Wagner
2026-11-18  9:55 ` superseded: " Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113150828.756836-41-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal