public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH proxmox 27/55] notify: fold mail-forwarder feature into send-impl
Date: Fri, 13 Nov 2026 16:08:00 +0100	[thread overview]
Message-ID: <20261113150828.756836-28-l.wagner@proxmox.com> (raw)
In-Reply-To: <20261113150828.756836-1-l.wagner@proxmox.com>

In the future, all users of proxmox-notify will use a single
notification worker to process queued notifications, which includes
forwarded mails as well. Hence it makes sense to merge both features.
The subject and body of the forwarded mail is now only parsed when the
mail is actually processed by an endpoint implementation, this makes
sure that the basic Notification type does not depend on the
mail-parser crate.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
 proxmox-notify/Cargo.toml                   |  3 ++-
 proxmox-notify/src/endpoints/common/mail.rs | 13 +++++++++++++
 proxmox-notify/src/endpoints/gotify.rs      |  5 +++--
 proxmox-notify/src/endpoints/sendmail.rs    |  1 -
 proxmox-notify/src/endpoints/smtp.rs        |  3 ---
 proxmox-notify/src/endpoints/webhook.rs     |  5 +++--
 proxmox-notify/src/notification.rs          | 16 +---------------
 7 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml
index ca5dc5d45..1971f5b60 100644
--- a/proxmox-notify/Cargo.toml
+++ b/proxmox-notify/Cargo.toml
@@ -66,6 +66,7 @@ send-impl = [
     "dep:lettre",
     "dep:handlebars",
     "dep:proxmox-config-digest",
+    "dep:mail-parser",
     "dep:percent-encoding",
     "dep:proxmox-base64",
     "dep:proxmox-http",
@@ -73,9 +74,9 @@ send-impl = [
     "dep:proxmox-human-byte",
     "dep:proxmox-section-config",
     "dep:proxmox-sendmail",
+    "proxmox-sendmail/mail-forwarder",
     "dep:proxmox-sys",
 ]
-mail-forwarder = ["dep:mail-parser", "dep:proxmox-sys", "proxmox-sendmail/mail-forwarder"]
 pve-context = ["dep:proxmox-sys", "legacy-matchers"]
 pbs-context = ["dep:proxmox-sys", "legacy-matchers"]
 legacy-matchers = []
diff --git a/proxmox-notify/src/endpoints/common/mail.rs b/proxmox-notify/src/endpoints/common/mail.rs
index 736f2ac66..fac4e759c 100644
--- a/proxmox-notify/src/endpoints/common/mail.rs
+++ b/proxmox-notify/src/endpoints/common/mail.rs
@@ -1,4 +1,5 @@
 use crate::Context;
+use crate::Error;
 
 /// Get list of email recipients from a list of email addresses and users.
 ///
@@ -34,6 +35,18 @@ pub(crate) fn get_recipients(
     recipients
 }
 
+/// Parse raw email message and return subject and plaintext body
+pub(crate) fn parse_subject_and_plaintext_body(raw_mail: &[u8]) -> Result<(String, String), Error> {
+    let message = mail_parser::MessageParser::default()
+        .parse(raw_mail)
+        .ok_or_else(|| Error::invalid_forwarded_message("could not parse forwarded email"))?;
+
+    let title = message.subject().unwrap_or_default().into();
+    let body = message.body_text(0).unwrap_or_default().into();
+
+    Ok((title, body))
+}
+
 #[cfg(test)]
 mod tests {
     use crate::context::test;
diff --git a/proxmox-notify/src/endpoints/gotify.rs b/proxmox-notify/src/endpoints/gotify.rs
index cf7d4cc68..bdb1e487d 100644
--- a/proxmox-notify/src/endpoints/gotify.rs
+++ b/proxmox-notify/src/endpoints/gotify.rs
@@ -7,6 +7,7 @@ use proxmox_http::client::sync::Client;
 use proxmox_http::{HttpClient, HttpOptions};
 
 use crate::api_types::{GotifyConfig, GotifyPrivateConfig};
+use crate::endpoints::common::mail;
 use crate::renderer::TemplateType;
 use crate::{Content, Context, Error, Notification, Severity, renderer};
 
@@ -48,8 +49,8 @@ impl Endpoint for GotifyEndpoint {
 
                 (rendered_title, rendered_message)
             }
-            #[cfg(feature = "mail-forwarder")]
-            Content::ForwardedMail { title, body, .. } => (title.clone(), body.clone()),
+
+            Content::ForwardedMail { raw, .. } => mail::parse_subject_and_plaintext_body(raw)?,
         };
 
         // We don't have a TemplateRenderer::Markdown yet, so simply put everything
diff --git a/proxmox-notify/src/endpoints/sendmail.rs b/proxmox-notify/src/endpoints/sendmail.rs
index bbed31b4f..0bad792f7 100644
--- a/proxmox-notify/src/endpoints/sendmail.rs
+++ b/proxmox-notify/src/endpoints/sendmail.rs
@@ -63,7 +63,6 @@ impl Endpoint for SendmailEndpoint {
                     Error::other_with_source("could not send mail via sendmail", err)
                 })
             }
-            #[cfg(feature = "mail-forwarder")]
             Content::ForwardedMail { raw, uid, .. } => {
                 Mail::forward(&recipients_str, &mailfrom, raw, *uid).map_err(|err| {
                     Error::other_with_source("could not forward mail via sendmail", err)
diff --git a/proxmox-notify/src/endpoints/smtp.rs b/proxmox-notify/src/endpoints/smtp.rs
index fa0810fbb..43dc1f7f4 100644
--- a/proxmox-notify/src/endpoints/smtp.rs
+++ b/proxmox-notify/src/endpoints/smtp.rs
@@ -132,7 +132,6 @@ impl Endpoint for SmtpEndpoint {
                         Error::invalid_config_with_source("could not build email message", err)
                     })?
             }
-            #[cfg(feature = "mail-forwarder")]
             Content::ForwardedMail { raw, .. } => build_forwarded_message(email_builder, raw)?,
         };
 
@@ -161,7 +160,6 @@ impl Endpoint for SmtpEndpoint {
 }
 
 /// Construct a lettre `Message` from a raw email message.
-#[cfg(feature = "mail-forwarder")]
 fn build_forwarded_message(
     email_builder: lettre::message::MessageBuilder,
     raw: &[u8],
@@ -312,7 +310,6 @@ mod tests {
         );
     }
 
-    #[cfg(feature = "mail-forwarder")]
     #[test]
     fn test_forward_message_from_raw() {
         use lettre::message::header::Date;
diff --git a/proxmox-notify/src/endpoints/webhook.rs b/proxmox-notify/src/endpoints/webhook.rs
index da2e189b4..2eaa71633 100644
--- a/proxmox-notify/src/endpoints/webhook.rs
+++ b/proxmox-notify/src/endpoints/webhook.rs
@@ -21,6 +21,7 @@ use proxmox_http::client::sync::Client;
 use proxmox_http::{HttpClient, HttpOptions};
 
 use crate::api_types::{HttpMethod, WebhookConfig, WebhookPrivateConfig};
+use crate::endpoints::common::mail;
 use crate::renderer::TemplateType;
 use crate::{Content, Context, Error, Notification, renderer};
 
@@ -93,8 +94,8 @@ impl WebhookEndpoint {
 
                 (rendered_title, rendered_message)
             }
-            #[cfg(feature = "mail-forwarder")]
-            Content::ForwardedMail { title, body, .. } => (title.clone(), body.clone()),
+
+            Content::ForwardedMail { raw, .. } => mail::parse_subject_and_plaintext_body(raw)?,
         };
 
         let mut fields = Map::new();
diff --git a/proxmox-notify/src/notification.rs b/proxmox-notify/src/notification.rs
index 426a2259a..f5b6ab6a6 100644
--- a/proxmox-notify/src/notification.rs
+++ b/proxmox-notify/src/notification.rs
@@ -62,15 +62,10 @@ pub enum Content {
         /// Data that can be used for template rendering.
         data: Value,
     },
-    #[cfg(feature = "mail-forwarder")]
     #[serde(rename_all = "kebab-case")]
     ForwardedMail {
         /// Raw mail contents
         raw: Vec<u8>,
-        /// Fallback title
-        title: String,
-        /// Fallback body
-        body: String,
         /// UID to use when calling sendmail
         #[allow(dead_code)] // Unused in some feature flag permutations
         uid: Option<u32>,
@@ -120,15 +115,8 @@ impl Notification {
             id: Uuid::generate(),
         }
     }
-    #[cfg(feature = "mail-forwarder")]
+
     pub fn new_forwarded_mail(raw_mail: &[u8], uid: Option<u32>) -> Result<Self, Error> {
-        let message = mail_parser::MessageParser::default()
-            .parse(raw_mail)
-            .ok_or_else(|| Error::invalid_forwarded_message("could not parse forwarded email"))?;
-
-        let title = message.subject().unwrap_or_default().into();
-        let body = message.body_text(0).unwrap_or_default().into();
-
         let mut additional_fields = HashMap::new();
         additional_fields.insert("hostname".into(), proxmox_sys::nodename().into());
         additional_fields.insert("type".into(), "system-mail".into());
@@ -139,8 +127,6 @@ impl Notification {
             // it is not filtered out.
             content: Content::ForwardedMail {
                 raw: raw_mail.into(),
-                title,
-                body,
                 uid,
             },
             metadata: Metadata {
-- 
2.47.3





  parent reply	other threads:[~2026-11-13 15:15 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 15:07 [PATCH many 00/55] notify: maintenance, PDM preparations, queue + worker Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 01/55] notify: disallow `unsafe` code Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 02/55] notify: refactor error type Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 03/55] notify: move `Endpoint` trait to endpoint module as pub(crate) Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 04/55] notify: use ConfigDigest instead of raw byte arrays Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 05/55] notify: remove static context and pass context as parameter Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 06/55] notify: matcher: drop unused field matcher verifiers Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 07/55] notify: introduce 'send-impl', 'api-impl' and 'api-types' features Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 08/55] notify: matcher: make matcher validation methods public Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 09/55] notify: make SendmailEndpoint and SmtpEndpoint private types Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 10/55] notify: move `send`, `test_target` and `Bus` to new `send` module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 11/55] notify: move Origin type to api_types module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 12/55] notify: move Target " Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 13/55] notify: move Config to config module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 14/55] notify: move Notification and sub-types to `notification` module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 15/55] notify: move schema module to api_types Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 16/55] notify: move check_matches from api_types::matcher to send::Bus Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 17/55] notify: move TemplateSource to context module Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 18/55] notify: config: cleanup helpers names and visibility Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 19/55] notify: config: rename section config parser/writer methods Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 20/55] notify: config: pass builtins explicitly when parsing section config Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 21/55] notify: implement PartialEq for all Config types Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 22/55] notify: use typed SectionConfigData Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 23/55] notify: api: api types: rename Deleteable* -> Deletable* Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 24/55] notify: context: parse builtin config only once Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 25/55] notify: context: parse proxy config in trait impl, not at the callsite Lukas Wagner
2026-11-13 15:07 ` [PATCH proxmox 26/55] notify: gate sub-modules with the appropriate feature flags Lukas Wagner
2026-11-13 15:08 ` Lukas Wagner [this message]
2026-11-13 15:08 ` [PATCH proxmox 28/55] notify: forwarded mails: don't hardcode severity and metadata fields Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 29/55] notify: don't pass uid when instantiating forwarded mail notifications Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 30/55] notify: derive PartialEq for Notification type Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 31/55] notify: add getters for severity and fields on " Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 32/55] notify: add test suite for " Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 33/55] notify: serialize raw, forwarded mail content as base64 Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 34/55] notify: unify code paths for legacy-sendmail and regular notifications Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 35/55] notify: add backwards-compat note to Notification type Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 36/55] notify: remove 'test_target' API Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 37/55] notify: replace notification instantiation with builder pattern Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 38/55] notify: add send receipts Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 39/55] notify: implement notification queue submitter Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 40/55] notify: context: add read_config Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 41/55] notify: queue: add queue consumer Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox 42/55] notify: queue: add worker task Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 43/55] notifications: don't ignore verification errors in legacy-sendmail mode Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 44/55] notifications: adapt to proxmox-notify API changes Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 45/55] api: notification: send test notification via proxmox_notify::send Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-backup 46/55] notifications: send all notifications via proxmox-notify's queue Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-perl-rs 47/55] pve: notify: adapt to changes in the public API of proxmox-notify Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-perl-rs 48/55] pve: notify: add `PVE::RS::Notify::enqueue` method Lukas Wagner
2026-11-13 15:08 ` [PATCH pve-cluster 49/55] notify: send notifications via notification queue Lukas Wagner
2026-11-13 15:08 ` [PATCH manager 50/55] vzdump: send legacy-sendmail notifications via simplified API Lukas Wagner
2026-11-13 15:08 ` [PATCH manager 51/55] pve-notify-worker: add new rust-based notification worker daemon Lukas Wagner
2026-11-13 15:08 ` [PATCH manager 52/55] debian: add 'pve-notify-worker' as a dependency Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-mail-forward 53/55] forward mails via notification queue Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-mail-forward 54/55] use return code to signal permanent or temporary failure Lukas Wagner
2026-11-13 15:08 ` [PATCH proxmox-mail-forward 55/55] limit size of mail read from stdin Lukas Wagner
2026-11-17  9:35 ` [PATCH many 00/55] notify: maintenance, PDM preparations, queue + worker Lukas Wagner
2026-11-18  9:55 ` superseded: " Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113150828.756836-28-l.wagner@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal