public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: applied: [PATCH qemu-server] test: cfg2cmd: add configs using every configurable device slot
Date: Thu, 12 Nov 2026 17:45:34 +0100	[thread overview]
Message-ID: <20261112164549.294842-1-f.ebner@proxmox.com> (raw)

From: Dominik Csapak <d.csapak@proxmox.com>

Applied this one from Dominik's staff repository (because of its size),
thanks!

Add one test each for i440fx, q35 and the aarch64 virt machine that
fills all device slots that can be combined in a single config, so
that changes to the generated devices and their addresses show up
for every index and not only for the few that the existing tests
happen to use.

Options that exclude each other are spread over the three configs.
The i440fx and aarch64 ones use virtio-scsi-single, the q35 one uses
lsi to get the additional SCSI controllers. Only the i440fx one uses
multiple QXL displays, and only the q35 one puts the passed through
devices on PCIe root ports.

Devices without a fixed address (virtiofs and the virtio vIOMMU) end
up on the root bus, so the number of virtiofs entries is limited to
the slots that remain free there. (This also highlights the current
issue hat they don't have an assigned pci address)

The aarch64 config has no IDE drives and only the first serial port, as
the virt machine has neither an IDE nor an ISA bus (which serial1+
require).

Extend the mocks with USB and directory mappings, which are needed
for mapped USB devices and virtiofs respectively.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/test/QemuServerTest/CommandLineMocks.pm |  47 ++-
 src/test/cfg2cmd/aarch64/full-virt.conf     | 145 ++++++++
 src/test/cfg2cmd/aarch64/full-virt.conf.cmd | 373 +++++++++++++++++++
 src/test/cfg2cmd/full-i440fx.conf           | 150 ++++++++
 src/test/cfg2cmd/full-i440fx.conf.cmd       | 393 ++++++++++++++++++++
 src/test/cfg2cmd/full-q35.conf              | 156 ++++++++
 src/test/cfg2cmd/full-q35.conf.cmd          | 372 ++++++++++++++++++
 7 files changed, 1635 insertions(+), 1 deletion(-)
 create mode 100644 src/test/cfg2cmd/aarch64/full-virt.conf
 create mode 100644 src/test/cfg2cmd/aarch64/full-virt.conf.cmd
 create mode 100644 src/test/cfg2cmd/full-i440fx.conf
 create mode 100644 src/test/cfg2cmd/full-i440fx.conf.cmd
 create mode 100644 src/test/cfg2cmd/full-q35.conf
 create mode 100644 src/test/cfg2cmd/full-q35.conf.cmd






                 reply	other threads:[~2026-11-12 16:46 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261112164549.294842-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal