From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 415D31FF0B6 for ; Thu, 12 Nov 2026 17:46:03 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 84C6421682; Thu, 12 Nov 2026 17:45:59 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: applied: [PATCH qemu-server] test: cfg2cmd: add configs using every configurable device slot Date: Thu, 12 Nov 2026 17:45:34 +0100 Message-ID: <20261112164549.294842-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794501954587 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.256 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CZ6SL2REAVJAJE7P5QXFSJM5A7FX3W6G X-Message-ID-Hash: CZ6SL2REAVJAJE7P5QXFSJM5A7FX3W6G X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Dominik Csapak Applied this one from Dominik's staff repository (because of its size), thanks! Add one test each for i440fx, q35 and the aarch64 virt machine that fills all device slots that can be combined in a single config, so that changes to the generated devices and their addresses show up for every index and not only for the few that the existing tests happen to use. Options that exclude each other are spread over the three configs. The i440fx and aarch64 ones use virtio-scsi-single, the q35 one uses lsi to get the additional SCSI controllers. Only the i440fx one uses multiple QXL displays, and only the q35 one puts the passed through devices on PCIe root ports. Devices without a fixed address (virtiofs and the virtio vIOMMU) end up on the root bus, so the number of virtiofs entries is limited to the slots that remain free there. (This also highlights the current issue hat they don't have an assigned pci address) The aarch64 config has no IDE drives and only the first serial port, as the virt machine has neither an IDE nor an ISA bus (which serial1+ require). Extend the mocks with USB and directory mappings, which are needed for mapped USB devices and virtiofs respectively. Signed-off-by: Dominik Csapak --- src/test/QemuServerTest/CommandLineMocks.pm | 47 ++- src/test/cfg2cmd/aarch64/full-virt.conf | 145 ++++++++ src/test/cfg2cmd/aarch64/full-virt.conf.cmd | 373 +++++++++++++++++++ src/test/cfg2cmd/full-i440fx.conf | 150 ++++++++ src/test/cfg2cmd/full-i440fx.conf.cmd | 393 ++++++++++++++++++++ src/test/cfg2cmd/full-q35.conf | 156 ++++++++ src/test/cfg2cmd/full-q35.conf.cmd | 372 ++++++++++++++++++ 7 files changed, 1635 insertions(+), 1 deletion(-) create mode 100644 src/test/cfg2cmd/aarch64/full-virt.conf create mode 100644 src/test/cfg2cmd/aarch64/full-virt.conf.cmd create mode 100644 src/test/cfg2cmd/full-i440fx.conf create mode 100644 src/test/cfg2cmd/full-i440fx.conf.cmd create mode 100644 src/test/cfg2cmd/full-q35.conf create mode 100644 src/test/cfg2cmd/full-q35.conf.cmd