From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server 3/4] qm: disk resize: propagate exit status from worker
Date: Mon, 9 Nov 2026 16:39:36 +0100 [thread overview]
Message-ID: <20261109154341.215638-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261109154341.215638-1-f.ebner@proxmox.com>
Commit 606d9d76 ("fix #2315: api: have resize endpoint spawn a worker
task") changed the 'resize_vm' API endpoint to return a worker UPID,
but forgot to adapt the related 'qm' CLI invocation, which then always
returned success if it reached the point of forking the worker.
Fix this and propagate the exit status from that worker.
Fixes: 606d9d76 ("fix #2315: api: have resize endpoint spawn a worker task")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PVE/CLI/qm.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm
index 2fb43246..f62fe036 100755
--- a/src/PVE/CLI/qm.pm
+++ b/src/PVE/CLI/qm.pm
@@ -1439,7 +1439,8 @@ our $cmddef = {
'move' =>
["PVE::API2::Qemu", 'move_vm_disk', ['vmid', 'disk', 'storage'], {%node}, $upid_exit],
rescan => [__PACKAGE__, 'rescan', []],
- resize => ["PVE::API2::Qemu", 'resize_vm', ['vmid', 'disk', 'size'], {%node}],
+ resize =>
+ ["PVE::API2::Qemu", 'resize_vm', ['vmid', 'disk', 'size'], {%node}, $upid_exit],
unlink => ["PVE::API2::Qemu", 'unlink', ['vmid'], {%node}],
},
--
2.47.3
next prev parent reply other threads:[~2026-11-09 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 15:39 [PATCH-SERIES storage/qemu-server/container 0/4] volume resize improvements, part 1 Fiona Ebner
2026-11-09 15:39 ` [PATCH storage 1/4] lvm: factor out helper for querying LV size Fiona Ebner
2026-11-09 15:39 ` [PATCH storage 2/4] lvm: qcow2 resize: do not abort if LV size is already large enough Fiona Ebner
2026-11-09 15:39 ` Fiona Ebner [this message]
2026-11-09 15:39 ` [PATCH container 4/4] pct: resize: propagate exit status from worker Fiona Ebner
2026-11-09 18:18 ` applied: [PATCH-SERIES storage/qemu-server/container 0/4] volume resize improvements, part 1 Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109154341.215638-4-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox