From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id CED0E1FF09B for ; Mon, 09 Nov 2026 16:44:08 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B39A02165A; Mon, 09 Nov 2026 16:43:50 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 3/4] qm: disk resize: propagate exit status from worker Date: Mon, 9 Nov 2026 16:39:36 +0100 Message-ID: <20261109154341.215638-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261109154341.215638-1-f.ebner@proxmox.com> References: <20261109154341.215638-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794239025070 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.288 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: F3DQ5ESSJM2D5Z55KQKLYG3Z7EAOS6UT X-Message-ID-Hash: F3DQ5ESSJM2D5Z55KQKLYG3Z7EAOS6UT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Commit 606d9d76 ("fix #2315: api: have resize endpoint spawn a worker task") changed the 'resize_vm' API endpoint to return a worker UPID, but forgot to adapt the related 'qm' CLI invocation, which then always returned success if it reached the point of forking the worker. Fix this and propagate the exit status from that worker. Fixes: 606d9d76 ("fix #2315: api: have resize endpoint spawn a worker task") Signed-off-by: Fiona Ebner --- src/PVE/CLI/qm.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/qm.pm b/src/PVE/CLI/qm.pm index 2fb43246..f62fe036 100755 --- a/src/PVE/CLI/qm.pm +++ b/src/PVE/CLI/qm.pm @@ -1439,7 +1439,8 @@ our $cmddef = { 'move' => ["PVE::API2::Qemu", 'move_vm_disk', ['vmid', 'disk', 'storage'], {%node}, $upid_exit], rescan => [__PACKAGE__, 'rescan', []], - resize => ["PVE::API2::Qemu", 'resize_vm', ['vmid', 'disk', 'size'], {%node}], + resize => + ["PVE::API2::Qemu", 'resize_vm', ['vmid', 'disk', 'size'], {%node}, $upid_exit], unlink => ["PVE::API2::Qemu", 'unlink', ['vmid'], {%node}], }, -- 2.47.3