[PATCH manager] fix #8281: ceph: unify add-storage parameter

[PATCH manager] fix #8281: ceph: unify add-storage parameter

[Kefu Chai]

Pool and CephFS creation both configure a PVE storage entry, but use
different option names. Use add-storage consistently to make the CLI less
confusing and easier to script, while keeping add_storages as a
deprecated alias for existing callers.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
---
 PVE/API2/Ceph/FS.pm       |  2 +-
 PVE/API2/Ceph/Pool.pm     | 14 ++++++++++----
 www/manager6/ceph/Pool.js |  2 +-
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/PVE/API2/Ceph/FS.pm b/PVE/API2/Ceph/FS.pm
index 8f2e8b63..e738552e 100644
--- a/PVE/API2/Ceph/FS.pm
+++ b/PVE/API2/Ceph/FS.pm
@@ -138,7 +138,7 @@ __PACKAGE__->register_method({
                 maximum => 32768,
             },
             'add-storage' => {
-                description => "Configure the created CephFS as storage for this cluster.",
+                description => "Add the created CephFS to the cluster storage configuration.",
                 type => 'boolean',
                 optional => 1,
                 default => 0,
diff --git a/PVE/API2/Ceph/Pool.pm b/PVE/API2/Ceph/Pool.pm
index 8fd11b82..c03a4799 100644
--- a/PVE/API2/Ceph/Pool.pm
+++ b/PVE/API2/Ceph/Pool.pm
@@ -438,14 +438,20 @@ __PACKAGE__->register_method({
         additionalProperties => 0,
         properties => {
             node => get_standard_option('pve-node'),
-            add_storages => {
-                description => "Configure VM and CT storage using the new pool. Defaults to"
-                    . " false for replicated pools and to true for erasure-coded pools"
+            'add-storage' => {
+                description => "Add the created Ceph pool to the cluster storage configuration."
+                    . " Defaults to false for replicated pools and to true for erasure-coded pools"
                     . " (since EC pools are typically only useful when wired up to storage).",
                 type => 'boolean',
                 optional => 1,
                 default => 0,
             },
+            add_storages => {
+                description => "Deprecated alias for 'add-storage'.",
+                alias => 'add-storage',
+                type => 'boolean',
+                optional => 1,
+            },
             'erasure-coding' => {
                 description => "Create an erasure coded pool for RBD with an accompaning"
                     . " replicated pool for metadata storage. With EC, the common ceph options 'size',"
@@ -466,7 +472,7 @@ __PACKAGE__->register_method({
 
         my $pool = my $name = extract_param($param, 'name');
         my $node = extract_param($param, 'node');
-        my $add_storages = extract_param($param, 'add_storages');
+        my $add_storages = extract_param($param, 'add-storage');
 
         my $rpcenv = PVE::RPCEnvironment::get();
         my $user = $rpcenv->get_user();
diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index a64230fb..39dcd5da 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -109,7 +109,7 @@ Ext.define('PVE.CephPoolInputPanel', {
                 value: '{isCreate}',
                 hidden: '{!isCreate}',
             },
-            name: 'add_storages',
+            name: 'add-storage',
             labelWidth: 140,
             autoEl: {
                 tag: 'div',
-- 
2.47.3