[PATCH manager v2 1/3] ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks

[Elias Huhsovitz <e.huhsovitz@proxmox.com>]

Currently, adding an unused (detached) disk requires the user to select
the disk and click the generic "Edit" button. This is confusing,
because: (1) The "Edit" label does not implicitly convey the action of
adding/attaching the disk. (2) The action to make a disk unused is
explicitly labeled "Detach", so a user expects a contrary "Attach"
button.

Harmonize the UI terminology by dynamically changing the "Edit" button
label to "Attach" when an unused disk is selected. This mirrors the
existing behavior of the "Remove" button, which changes to "Detach" for
used disks.

To prevent the toolbar from moving when switching between labels of
different lengths, change the edit button to a proxmoxAltTextButton.

Signed-off-by: Elias Huhsovitz <e.huhsovitz@proxmox.com>
---
 www/manager6/lxc/Resources.js     | 7 +++++--
 www/manager6/qemu/HardwareView.js | 8 +++++++-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
index df513bb7..40321d03 100644
--- a/www/manager6/lxc/Resources.js
+++ b/www/manager6/lxc/Resources.js
@@ -217,15 +217,17 @@ Ext.define('PVE.lxc.RessourceView', {
             });
         };
 
-        var edit_btn = new Proxmox.button.Button({
+        let edit_btn = new Proxmox.button.AltText({
             text: gettext('Edit'),
+            defaultText: gettext('Edit'),
+            altText: gettext('Attach'),
             selModel: me.selModel,
             disabled: true,
             enableFn: function (rec) {
                 if (!rec) {
                     return false;
                 }
-                var rowdef = rows[rec.data.key];
+                let rowdef = rows[rec.data.key];
                 return !!rowdef.editor;
             },
             handler: function () {
@@ -332,6 +334,7 @@ Ext.define('PVE.lxc.RessourceView', {
                 }
             }
             edit_btn.setDisabled(noedit);
+            edit_btn.setText(isUnusedDisk ? edit_btn.altText : edit_btn.defaultText);
 
             volumeaction_btn.setDisabled(!isDisk || !diskCap);
             move_menuitem.setDisabled(isUnusedDisk);
diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
index 8b932995..3eebd05f 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/manager6/qemu/HardwareView.js
@@ -472,8 +472,10 @@ Ext.define('PVE.qemu.HardwareView', {
             }
         };
 
-        let edit_btn = new Proxmox.button.Button({
+        let edit_btn = new Proxmox.button.AltText({
             text: gettext('Edit'),
+            defaultText: gettext('Edit'),
+            altText: gettext('Attach'),
             selModel: sm,
             disabled: true,
             handler: run_editor,
@@ -818,6 +820,10 @@ Ext.define('PVE.qemu.HardwareView', {
                     (isDisk && !diskCap),
             );
 
+            edit_btn.setText(
+                isUnusedDisk && !isCloudInit ? edit_btn.altText : edit_btn.defaultText,
+            );
+
             diskaction_btn.setDisabled(
                 pending || !diskCap || isCloudInit || !(isDisk || isEfi || tpmMoveable),
             );
-- 
2.47.3