public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH manager v2 0/3] ui: lxc/qemu: reduce ambiguity when attaching unused disk
Date: Tue,  3 Nov 2026 10:27:27 +0100	[thread overview]
Message-ID: <20261103092730.21635-1-e.huhsovitz@proxmox.com> (raw)

Small UI quality of life improvements to reduce the ambiguity of
attaching/adding an unused disk to vm/container:
* rename 'Edit' button to 'Attach' for unused disks.
* Convert existing buttons that display altText to
  `Proxmox.button.AltText`
* Make button ordering of lxc/qemu hardware options consistent

This also came it in a forum post [0] some time ago.

[0] https://forum.proxmox.com/threads/how-do-i-reattach-a-disk-to-vm.108339/

Changes v1->v2:
---------------
* utilize Proxmox.button.AltText for all buttons displaying alt text
* re-order buttons in hardware/resources tab

Previous Versions
-----------------
v1: https://lore.proxmox.com/pve-devel/20261030124235.124337-1-e.huhsovitz@proxmox.com/

Elias Huhsovitz (3):
  ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks
  ui: lxc/qemu: convert buttons displaying altText to
    proxmoxAltTextButton
  ui: qemu: re-order buttons in hardware tab to match lxc layout

 www/manager6/lxc/Resources.js     | 24 ++++++------------------
 www/manager6/qemu/HardwareView.js | 27 +++++++++------------------
 2 files changed, 15 insertions(+), 36 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-11-03  9:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  9:27 Elias Huhsovitz [this message]
2026-11-03  9:27 ` [PATCH manager v2 1/3] ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks Elias Huhsovitz
2026-11-03  9:27 ` [PATCH manager v2 2/3] ui: lxc/qemu: convert buttons displaying altText to proxmoxAltTextButton Elias Huhsovitz
2026-11-03  9:27 ` [PATCH manager v2 3/3] ui: qemu: re-order buttons in hardware tab to match lxc layout Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261103092730.21635-1-e.huhsovitz@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal