From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v5 24/27] ui: guest destroy: use let for non-constant variable bindings
Date: Tue, 3 Nov 2026 09:43:25 +0100 [thread overview]
Message-ID: <20261103084328.203492-25-a.bied-charreton@proxmox.com> (raw)
In-Reply-To: <20261103084328.203492-1-a.bied-charreton@proxmox.com>
See JS Style Guide [0].
[0] https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables
Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
www/manager6/window/SafeDestroyGuest.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/window/SafeDestroyGuest.js b/www/manager6/window/SafeDestroyGuest.js
index ee0c649c..45b277e5 100644
--- a/www/manager6/window/SafeDestroyGuest.js
+++ b/www/manager6/window/SafeDestroyGuest.js
@@ -37,10 +37,10 @@ Ext.define('PVE.window.SafeDestroyGuest', {
getParams: function () {
let me = this;
- const purgeCheckbox = me.lookupReference('purgeCheckbox');
+ let purgeCheckbox = me.lookupReference('purgeCheckbox');
me.params.purge = purgeCheckbox.checked ? 1 : 0;
- const destroyUnreferencedCheckbox = me.lookupReference('destroyUnreferencedCheckbox');
+ let destroyUnreferencedCheckbox = me.lookupReference('destroyUnreferencedCheckbox');
me.params['destroy-unreferenced-disks'] = destroyUnreferencedCheckbox.checked ? 1 : 0;
return me.callParent();
--
2.47.3
next prev parent reply other threads:[~2026-11-03 8:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:43 [PATCH container/docs/firewall/manager/network/qemu-server v5 00/27] handle dangling references when firewall objects go away Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 01/27] firewall: move object reference helpers to their own module Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 02/27] firewall: references: add helpers to update object references Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 03/27] firewall: references: log the references an object update touched Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 04/27] firewall: references: add wrappers for the SDN-generated IPSets Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 05/27] firewall: parser: do not log errors for disabled rules Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 06/27] firewall: ipset: add option to handle dangling references on rename Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 07/27] firewall: ipset: add option to handle dangling references on delete Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 08/27] firewall: aliases: add option to handle dangling references on rename Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 09/27] firewall: aliases: add option to handle dangling references on delete Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 10/27] firewall: api: run reference updates as tasks Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 11/27] firewall: tests: add tests for object reference updates Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 12/27] firewall: references: handle security groups Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 13/27] firewall: groups: add option to handle dangling references on rename Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-firewall v5 14/27] fix #8176: firewall: groups: handle dangling references on delete Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-network v5 15/27] apply: add option to handle dangling references on VNet deletion Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH qemu-server v5 16/27] api: destroy_vm: add option to handle dangling IPSet references Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-container v5 17/27] " Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-docs v5 18/27] firewall: remove trailing spaces Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-docs v5 19/27] firewall: document renaming and removing objects Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-manager v5 20/27] ui: firewall: add a common widget for handling dangling references Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-manager v5 21/27] ui: firewall: ipset: add controls for " Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-manager v5 22/27] ui: firewall: aliases: " Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-manager v5 23/27] ui: sdn: apply: add control for dangling IPSet references Arthur Bied-Charreton
2026-11-03 8:43 ` Arthur Bied-Charreton [this message]
2026-11-03 8:43 ` [PATCH pve-manager v5 25/27] ui: guest destroy: " Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-manager v5 26/27] ui: firewall: show the task for reference updates Arthur Bied-Charreton
2026-11-03 8:43 ` [PATCH pve-manager v5 27/27] ui: firewall: groups: add controls for dangling references Arthur Bied-Charreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103084328.203492-25-a.bied-charreton@proxmox.com \
--to=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox