[PATCH pve-manager v5 23/27] ui: sdn: apply: add control for dangling IPSet references

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Applying an SDN configuration that removes a VNet also removes the
four IPSets auto-generated for it [0], so rules referencing those no
longer resolve and are dropped from the generated ruleset.

Replace the plain confirmation message box with a window carrying the
shared selector, so those rules can be disabled or deleted in the same
step. The Apply button first queries the pending VNets, and the window
only shows the selector if the apply actually removes one, since there
is nothing to decide otherwise.

[0] https://pve.proxmox.com/wiki/Software-Defined_Network#pvesdn_firewall_integration

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/sdn/StatusView.js | 118 +++++++++++++++++++++++++++------
 1 file changed, 98 insertions(+), 20 deletions(-)

diff --git a/www/manager6/sdn/StatusView.js b/www/manager6/sdn/StatusView.js
index fada5041..ce919639 100644
--- a/www/manager6/sdn/StatusView.js
+++ b/www/manager6/sdn/StatusView.js
@@ -1,3 +1,87 @@
+// scanned by asciidoc-pve, so the anchor lands in the documentation index
+const VNET_IPSETS_HELP = {
+    onlineHelp: 'pve_firewall_automatically_generated_ipsets',
+};
+
+Ext.define('PVE.sdn.ApplyWindow', {
+    extend: 'Proxmox.window.Edit',
+    alias: 'widget.pveSdnApplyWindow',
+
+    title: gettext('Apply SDN Configuration'),
+
+    url: '/cluster/sdn',
+    method: 'PUT',
+    isCreate: true,
+    submitText: gettext('Apply'),
+    width: 600,
+
+    removedVnets: [],
+
+    initComponent: function () {
+        let me = this;
+
+        me.items = [
+            {
+                xtype: 'displayfield',
+                value: gettext(
+                    'Applying pending SDN changes will also apply any pending local node network changes.',
+                ),
+            },
+        ];
+
+        if (me.removedVnets.length !== 0) {
+            let removedHint = Ext.htmlEncode(
+                Ext.String.format(
+                    gettext('This removes the following VNet(s): {0}.'),
+                    me.removedVnets.join(', '),
+                ),
+            );
+            let helpLink = Ext.htmlEncode(Proxmox.Utils.get_help_link(VNET_IPSETS_HELP.onlineHelp));
+            let helpLabel = Ext.htmlEncode(gettext('their auto-generated IPSets'));
+            let refsHint = Ext.String.format(
+                gettext('Firewall rules referencing {0} will no longer resolve.'),
+                `<a target="_blank" href="${helpLink}">${helpLabel}</a>`,
+            );
+
+            me.items.push(
+                {
+                    xtype: 'displayfield',
+                    userCls: 'pmx-hint',
+                    value: `${removedHint}<br>${refsHint}`,
+                },
+                {
+                    xtype: 'pveFirewallReferenceAction',
+                    name: 'dangling-ipset-references',
+                    preferredValue: 'drop',
+                    fieldLabel: gettext('Referencing rules'),
+                    labelWidth: 200,
+                    referenceActions: [
+                        {
+                            text: gettext('Keep'),
+                            value: 'keep',
+                            description: gettext(
+                                "Do not touch firewall rules referencing this VNet's IPSets.",
+                            ),
+                        },
+                        {
+                            text: gettext('Disable'),
+                            value: 'disable',
+                            description: gettext("Disable firewall rules referencing this VNet's IPSets."),
+                        },
+                        {
+                            text: gettext('Delete'),
+                            value: 'drop',
+                            description: gettext("Delete firewall rules referencing this VNet's IPSets."),
+                        },
+                    ],
+                },
+            );
+        }
+
+        me.callParent();
+    },
+});
+
 Ext.define(
     'PVE.sdn.StatusView',
     {
@@ -45,26 +129,20 @@ Ext.define(
                     {
                         text: gettext('Apply'),
                         handler: function () {
-                            Ext.Msg.show({
-                                title: gettext('Confirm'),
-                                icon: Ext.Msg.QUESTION,
-                                msg: gettext(
-                                    'Applying pending SDN changes will also apply any pending local node network changes. Proceed?',
-                                ),
-                                buttons: Ext.Msg.YESNO,
-                                callback: function (btn) {
-                                    if (btn === 'yes') {
-                                        Proxmox.Utils.API2Request({
-                                            url: '/cluster/sdn/',
-                                            method: 'PUT',
-                                            waitMsgTarget: me,
-                                            failure: (response) =>
-                                                Ext.Msg.alert(
-                                                    gettext('Error'),
-                                                    response.htmlStatus,
-                                                ),
-                                        });
-                                    }
+                            Proxmox.Utils.API2Request({
+                                url: '/cluster/sdn/vnets',
+                                method: 'GET',
+                                params: { pending: 1 },
+                                waitMsgTarget: me,
+                                failure: (response) =>
+                                    Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+                                success: function (response) {
+                                    Ext.create('PVE.sdn.ApplyWindow', {
+                                        removedVnets: response.result.data
+                                            .filter((vnet) => vnet.state === 'deleted')
+                                            .map((vnet) => vnet.vnet),
+                                        autoShow: true,
+                                    });
                                 },
                             });
                         },
-- 
2.47.3