[PATCH installer v4 14/30] install: config: add option for setting up vlan on management interface

[Christoph Heiss <c.heiss@proxmox.com>]

Prerequisite for the rest of the installer to support setting up a VLAN
interface for management during installation.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Changes v3 -> v4:
  * no changes

Changes v2 -> v3:
  * new patch

 Proxmox/Install/Config.pm | 32 ++++++++++++++++++++++++++++++++
 Proxmox/Sys/Net.pm        |  9 +++++++++
 2 files changed, 41 insertions(+)

diff --git a/Proxmox/Install/Config.pm b/Proxmox/Install/Config.pm
index 967712a..3df66c2 100644
--- a/Proxmox/Install/Config.pm
+++ b/Proxmox/Install/Config.pm
@@ -118,6 +118,13 @@ my sub init_cfg {
             primary_interface => undef,
         },
 
+        # Options for setting up a VLAN on the management interface.
+        mngmt_vlan => {
+            enabled => 0,
+            # VLAN ID to configure.
+            vid => 0,
+        },
+
         # maps mac address -> custom name
         # if set to a hash, enables interface name pinning for all interfaces
         network_interface_pin_map => undef,
@@ -304,6 +311,31 @@ sub get_mngmt_bond_enabled { # virtual config
     return scalar(get_mngmt_bond_opt('members')->@*) >= 2;
 }
 
+sub set_mngmt_vlan_opt {
+    my ($k, $v) = @_;
+    my $opts = get('mngmt_vlan');
+
+    croak "unknown management vlan option key '$k'\n" if !exists($opts->{$k});
+
+    if ($k eq 'vid') {
+        die "invalid VLAN tag '$v'\n"
+            if !Proxmox::Sys::Net::is_valid_vlan_id($v);
+        $opts->{$k} = int($v);
+    } else {
+        $opts->{$k} = $v;
+    }
+}
+
+sub get_mngmt_vlan_opt {
+    my ($k) = @_;
+    my $opts = get('mngmt_vlan');
+    return defined($k) ? $opts->{$k} : $opts;
+}
+
+sub get_mngmt_vlan_enabled {
+    return get_mngmt_vlan_opt('enabled') != 0;
+}
+
 sub set_network_interface_pin_map { set_key('network_interface_pin_map', $_[0]); }
 sub get_network_interface_pin_map { return get('network_interface_pin_map'); }
 
diff --git a/Proxmox/Sys/Net.pm b/Proxmox/Sys/Net.pm
index 630d96a..485c9e9 100644
--- a/Proxmox/Sys/Net.pm
+++ b/Proxmox/Sys/Net.pm
@@ -17,6 +17,7 @@ our @EXPORT_OK = qw(
     validate_link_pin_map
     is_valid_bond_mode
     is_valid_bond_hash_policy
+    is_valid_vlan_id
     MIN_IFNAME_LEN
     MAX_IFNAME_LEN
     DEFAULT_PIN_PREFIX
@@ -484,4 +485,12 @@ sub is_valid_bond_hash_policy {
     return exists($valid->{$policy});
 }
 
+# Returns whether the given ID is a valid VLAN ID.
+# 0 and 4095 are reserved, and 1 is the default PVID of VLAN-aware bridges on Linux.
+sub is_valid_vlan_id {
+    my ($vid) = @_;
+
+    return defined($vid) && $vid =~ m/^[0-9]+$/ && $vid >= 2 && $vid <= 4094;
+}
+
 1;
-- 
2.55.0