public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Elias Huhsovitz <e.huhsovitz@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Elias Huhsovitz <e.huhsovitz@proxmox.com>
Subject: [PATCH proxmox-perl-rs v2 0/3] makefile: reduce ambiguity for targets: all/install/upload
Date: Fri, 30 Oct 2026 14:25:30 +0100	[thread overview]
Message-ID: <20261030132533.150795-1-e.huhsovitz@proxmox.com> (raw)

I encounted some minor inconsistencies in the Makefile:
* make install only installs from release dir (Even though 'make all'
  generates a debug build per default)
* File Fixup.pm is used inside a target but not specified as a
  prerequisite.
* unsued variable for upload target.

Some small patches to fix them.

Not implemented
---------------
Some minor fixes (such as replacing shell pwd with CURDIR) are not in
this series, because they have already been address in this patch
by Max:
https://lore.proxmox.com/pve-devel/20260807090809.101155-1-m.carrara@proxmox.com/

Changes v1->v2
--------------
* fix typo in commit message of patch 2
* utilize UPLOAD_DIST variable in common/pkg/Makefile

Previous versions:
------------------
v1: https://lore.proxmox.com/pve-devel/20261027104935.49190-1-e.huhsovitz@proxmox.com/

Summary of changes
------------------
Elias Huhsovitz (3):
  makefile: use TARGET_DIR variable for install target
  makefile: add Fixup.pm as prerequisite for $(BUILDDIR)
  makefile: use UPLOAD_DIST variable

 common/pkg/Makefile | 2 +-
 pmg-rs/Makefile     | 8 ++++----
 pve-rs/Makefile     | 8 ++++----
 3 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-10-30 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 13:25 Elias Huhsovitz [this message]
2026-10-30 13:25 ` [PATCH proxmox-perl-rs v2 1/3] makefile: use TARGET_DIR variable for install target Elias Huhsovitz
2026-10-30 13:25 ` [PATCH proxmox-perl-rs v2 2/3] makefile: add Fixup.pm as prerequisite for $(BUILDDIR) Elias Huhsovitz
2026-10-30 13:25 ` [PATCH proxmox-perl-rs v2 3/3] makefile: use UPLOAD_DIST variable Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261030132533.150795-1-e.huhsovitz@proxmox.com \
    --to=e.huhsovitz@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal